Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test name shadowing #4672

Closed
michaeljklein opened this issue Mar 28, 2024 · 0 comments · Fixed by #4799
Closed

Test name shadowing #4672

michaeljklein opened this issue Mar 28, 2024 · 0 comments · Fixed by #4799
Assignees
@michaeljklein
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

Problem

We could have more tests for name shadowing.

Happy Case

Make tests for all of the major pairs of name shadowing and ensure that they behave as expected, i.e. the "newer" name is used when expected and there's a name resolution conflict when expected:

  • module name
  • package name
  • global constant
  • let binding
  • function: name, generic parameter, parameter
  • trait: name, generic parameter, method name
  • struct: name, field
  • match pattern
  • lambda function parameter
  • conflict between dependencies

Project Impact

Nice-to-have

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@michaeljklein michaeljklein added the enhancement New feature or request label Mar 28, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Mar 28, 2024
@michaeljklein michaeljklein mentioned this issue Apr 12, 2024
Merged
5 tasks
@TomAFrench TomAFrench moved this from 📋 Backlog to 🏗 In progress in Noir Apr 26, 2024
github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
@michaeljklein @jfecher @TomAFrench
chore: adding name shadowing tests template program (#4799)
4b16c7f 
# Description

## Problem\*

Resolves #4672

## Summary\*

The plan is to generate variations of a test program that checks for
several types of name shadowing, and then ensure that we get expected
results or errors for different combinations of name conflicts.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: jfecher <[email protected]>
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Noir May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaeljklein michaeljklein

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: adding name shadowing tests template program noir-lang/noir
1 participant
@michaeljklein