Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply attributes to a trait #5477

Closed
Tracked by #4594
jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5496
Closed
Tracked by #4594

Apply attributes to a trait #5477

jfecher opened this issue Jul 10, 2024 · 0 comments · Fixed by #5496
Labels
enhancement New feature or request

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 10, 2024

Problem

Comptime attribute functions are only allowed Struct definitions currently.

Happy Case

We should allow these on trait definitions (and other items) as well.

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@jfecher jfecher added the enhancement New feature or request label Jul 10, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 10, 2024
@jfecher jfecher changed the title Apply annotations to a trait Apply attributes to a trait Jul 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
# Description

## Problem\*

Resolves #5477

## Summary\*

Adds:
- The ability to run `comptime` attribute functions on traits &
functions in the program
- The `TraitDefinition` type
- The `FunctionDefinition` type
- The `Module` type - the only one of the new types which you still
can't run attributes on. See:
#5495. Running these on modules
is a bit more difficult since modules don't have an entry in
`CollectedItems` to run them on. So I'm delaying this for a later PR.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [x] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant