Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutating an &mut value in the interpreter does not change the original value #5504

Closed
jfecher opened this issue Jul 12, 2024 · 0 comments · Fixed by #5517
Closed

Mutating an &mut value in the interpreter does not change the original value #5504

jfecher opened this issue Jul 12, 2024 · 0 comments · Fixed by #5517
Labels
bug Something isn't working

Comments

@jfecher
Copy link
Contributor

jfecher commented Jul 12, 2024

Aim

fn main() {
    comptime {
        let mut x = 0;
        let y = &mut x;
        *y = 1;
        assert(x == 1);
    }
}

Expected Behavior

The program to pass

Bug

Assertion failure; x is still 0

To Reproduce

Project Impact

None

Impact Context

No response

Workaround

None

Workaround Description

No response

Additional Context

No response

Installation Method

None

Nargo Version

No response

NoirJS Version

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response
@jfecher jfecher added the bug Something isn't working label Jul 12, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jul 12, 2024
This was referenced Jul 15, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 15, 2024
@jfecher @TomAFrench
fix: Mutability in the comptime interpreter (#5517)
8cab4ac 
# Description

## Problem\*

Resolves #5504

## Summary\*

Mutable variables weren't wrapped in a mutable reference before like
they are in SSA - they are now.

## Additional Context

This is an alternate version from the last PR - I've cherry-picked the
last PR so this can be merged into master instead of another branch.

## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[For Experimental Features]** Documentation to be submitted in a
separate PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Mutability in the comptime interpreter noir-lang/noir
1 participant
@jfecher