LSP hover stopped working in some cases #5516
Labels
bug
Something isn't working
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 15, 2024
# Description ## Problem Resolves #5516 ## Summary It seems hover broke in 70dabfa . However, our tests still pass. I still don't understand why it only breaks when the request comes from an actual VS Code instance and not in tests... but for now I'd rather revert the commit that broke it and eventually try to do the refactor again, because having hover is pretty nice :-) ## Additional Context None. ## Documentation\* Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Aim
Hovering over, for example, "BoundedVec" in a line like
use std::collections::bounded_vec::BoundedVecwouldn't show hover information and instead show an LSP error.This broke in 70dabfa where a refactor was made to avoid duplicating a module's parent ID in
ModuleAttributes.Expected Behavior
LSP hover works as before.
Bug
LSP hover doesn't work anymore.
To Reproduce
No response
Project Impact
None
Impact Context
No response
Workaround
None
Workaround Description
No response
Additional Context
No response
Installation Method
None
Nargo Version
No response
NoirJS Version
No response
Would you like to submit a PR for this Issue?
Yes
Support Needs
No response
The text was updated successfully, but these errors were encountered: