Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug_asserts for internal compiler errors #781

Closed
kevaundray opened this issue Feb 9, 2023 · 0 comments · Fixed by #924
Closed

Remove debug_asserts for internal compiler errors #781

kevaundray opened this issue Feb 9, 2023 · 0 comments · Fixed by #924
Labels
enhancement New feature or request good first issue Good for newcomers refactor

Comments

@kevaundray
Copy link
Contributor

Problem

Debug asserts are optimised out in Release builds, so if its an ICE, it won't get triggered in the binaries.

Solution

Change debug_asserts to asserts

Alternatives considered

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: debug_assert to assert supernovahs/noir
1 participant
@kevaundray