chore: debug_assert to assert

[supernovahs]

Changing debug_assert to assert

Resolves #781

[guipublic]

I disagree with the issue #781, and hence with this PR.
"Debug_assert are optimised in release build": this is exactly their feature, and so the reason why we use debug_assert instead of assert. Changing them to assert because of this, is simply pure non sense.

[kevaundray]

Hi @guipublic thank you for sharing your opinion on this matter.

Reading the documentation on debug_assert here

It states that:

An unchecked assertion allows a program in an inconsistent state to keep running, which might have unexpected consequences but does not introduce unsafety as long as this only happens in safe code. The performance cost of assertions, however, is not measurable in general. Replacing assert! with debug_assert! is thus only encouraged after thorough profiling, and more importantly, only in safe code!

As such, I think its okay to use assertions everywhere and we can re-evaluate if there are any significant performance impacts. What we care about is safe code and if there are invariants that need to be upheld, we should not by default omit those regardless of the build

Documentation recommends this -- if there are any issues, lets continue on the issue