Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nargo)!: Modify nargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml #2034

Closed
wants to merge 8 commits into from

Conversation

Ethan-000
Copy link
Contributor

@Ethan-000 Ethan-000 commented Jul 25, 2023

Description

Problem*

Resolves #700
Resolves #1851

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@Ethan-000 Ethan-000 changed the title chore(nargo): change nargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml chore(nargo): Modifynargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml Jul 25, 2023
@TomAFrench TomAFrench changed the title chore(nargo): Modifynargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml chore(nargo)!: Modifynargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml Aug 2, 2023
@TomAFrench TomAFrench changed the title chore(nargo)!: Modifynargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml chore(nargo)!: Modify nargo check to only do type checking and add nargo tomlgen to generate Prover.toml and Verifier.toml Aug 2, 2023
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a look at this next week.

@phated
Copy link
Contributor

phated commented Aug 4, 2023

The tooling team is still in the process of discussing how these will be handled in the future so I'm converting this to a draft for the time being.

@phated phated marked this pull request as draft August 4, 2023 19:21
@TomAFrench TomAFrench closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nargo check is not just a check nargo check doesn't rewrite Prover.toml and Verifier.toml
4 participants