chore: remove noirc_abi
dependency from noirc_evaluator
#3492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR aims to simplify our internal dependencies within the compiler. Previously it was the responsibility of
noirc_evaluator
to construct the circuit's ABI although this means that the "deepest" level of the compiler was responsible for creating the user facing interface for it. We'd also need to pass in theContext
object purely for the purpose of constructing this.Instead we should pass out the list of witnesses which are arguments to the circuit and construct the ABI from this up in
noirc_driver
which is a more natural location to perform this task.As part of this I've removed the
Range
behaviour of the ABI where it has leaked into the compiler. This is intended to reduce the size of the serialised ABI but we don't require this in the compiler itself and it just causes additional complexity.Additional Context
Something that this PR highlights is how implicit we are about how witnesses get mapped to function inputs. We should follow up with some documentation, etc. which describes how we'll generate these.
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.