Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove noirc_abi dependency from noirc_evaluator #3492

Merged
merged 11 commits into from
Nov 21, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR aims to simplify our internal dependencies within the compiler. Previously it was the responsibility of noirc_evaluator to construct the circuit's ABI although this means that the "deepest" level of the compiler was responsible for creating the user facing interface for it. We'd also need to pass in the Context object purely for the purpose of constructing this.

Instead we should pass out the list of witnesses which are arguments to the circuit and construct the ABI from this up in noirc_driver which is a more natural location to perform this task.

As part of this I've removed the Range behaviour of the ABI where it has leaked into the compiler. This is intended to reduce the size of the serialised ABI but we don't require this in the compiler itself and it just causes additional complexity.

Additional Context

Something that this PR highlights is how implicit we are about how witnesses get mapped to function inputs. We should follow up with some documentation, etc. which describes how we'll generate these.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title Tf/remove abi dep from evaluator chore: remove noirc_abi dependency from noirc_evaluator Nov 14, 2023
@TomAFrench TomAFrench marked this pull request as ready for review November 17, 2023 16:37
@TomAFrench TomAFrench added this pull request to the merge queue Nov 21, 2023
Merged via the queue into master with commit 008a431 Nov 21, 2023
@TomAFrench TomAFrench deleted the tf/remove-abi-dep-from-evaluator branch November 21, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants