Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite constraints on binary instructions in terms of their inputs #4064

Closed
wants to merge 1 commit into from

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jan 17, 2024

Description

Problem*

Resolves

Summary*

This PR is blocked by #4065 and #4060 as otherwise we get a large number of duplicated constraints from multiple constraints being decomposed into the same base set of constraints.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Changes to circuit sizes

Generated at commit: ca0f57c326d1c6c26c17e90675ef78e0e52b0c9b, compared to commit: 49e1b0c0d45565f3e87469b77f2fef0c283f6ea1

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
references +40 ❌ +666.67% +37 ❌ +176.19%
slice_dynamic_index +238 ❌ +18.00% +452 ❌ +6.59%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
references 46 (+40) +666.67% 58 (+37) +176.19%
slice_dynamic_index 1,560 (+238) +18.00% 7,307 (+452) +6.59%
slices 417 (+106) +34.08% 3,531 (+115) +3.37%
7_function 256 (+22) +9.40% 3,027 (+20) +0.67%
u128 781 (-1) -0.13% 4,782 (-1) -0.02%

@TomAFrench TomAFrench force-pushed the tf/ssa-constant-backpropagation branch from 9ff50fb to bd60004 Compare January 17, 2024 15:29
@TomAFrench TomAFrench changed the base branch from tf/bring-back-constraint-cache to master January 17, 2024 15:29
@TomAFrench TomAFrench force-pushed the tf/ssa-constant-backpropagation branch 2 times, most recently from 1874a1e to ffe43a1 Compare January 17, 2024 19:31
@TomAFrench TomAFrench changed the base branch from master to tf/bring-back-constraint-cache January 17, 2024 19:32
@TomAFrench TomAFrench force-pushed the tf/ssa-constant-backpropagation branch 2 times, most recently from 5f709d7 to a54c1b8 Compare January 18, 2024 02:21
@TomAFrench TomAFrench force-pushed the tf/bring-back-constraint-cache branch 5 times, most recently from 8313eed to dd450c3 Compare February 1, 2024 13:55
@TomAFrench TomAFrench force-pushed the tf/bring-back-constraint-cache branch from dd450c3 to fac2a3e Compare February 7, 2024 10:34
@TomAFrench TomAFrench force-pushed the tf/ssa-constant-backpropagation branch from a54c1b8 to af0e04f Compare February 7, 2024 12:03
Base automatically changed from tf/bring-back-constraint-cache to master February 7, 2024 17:56
@TomAFrench TomAFrench changed the base branch from master to tf/reactivate-bubble-up-constrains February 7, 2024 19:38
@TomAFrench TomAFrench force-pushed the tf/ssa-constant-backpropagation branch from 76655c2 to cad8249 Compare June 22, 2024 14:21
@TomAFrench TomAFrench changed the base branch from tf/reactivate-bubble-up-constrains to master June 22, 2024 14:21
@TomAFrench TomAFrench force-pushed the tf/ssa-constant-backpropagation branch from cad8249 to 42d200e Compare June 22, 2024 14:25
@TomAFrench TomAFrench closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant