-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: non-deterministic array sort #4279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
This PR also resolves #4261 |
jfecher
reviewed
Feb 7, 2024
jfecher
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #4171
We have an intrinsic sort function to do sorting on numeric arrays. It allows field elements but fail with them.
At the same time we have a more generic sort_via method with works with custom ordering function but it has bad performance.
Summary*
I have rationalised the sorting functions for arrays, we now have only one which works on any type and support custom ordering functions.
The new sort function benefits from dynamic arrays and does not need sorting networks, so I was able to remove a lot of deprecated code. See below for the impact on performance.
The issue 4171 is resolved by specifying the Ord trait for array elements.
Additional Context
So we have 3 sort functions:
the new one 'ultra_sort'
the pre-ultra plonk 'array_sort'
the customisable one, 'sort_via'
With this PR, we only keep the new one 'ultra_sort'. Here how it compares with the others:
Sorting an array of 10 elements:
Sorting an array of 100 elements:
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.