Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Incorrect wrapping_add Usage in Integers Tutorial #4295

Merged
merged 1 commit into from
Feb 7, 2024
Merged

chore: Fix Incorrect wrapping_add Usage in Integers Tutorial #4295

merged 1 commit into from
Feb 7, 2024

Conversation

joaolago1113
Copy link
Contributor

This pull request addresses an issue identified in the integers tutorial, where the wrapping_add function was incorrectly called with a single argument (x + y) instead of the correct form with two separate arguments (x, y).

Changes Made

The documentation has been updated to reflect the correct usage:

- std::wrapping_add(x + y)
+ std::wrapping_add(x, y)

Acknowledgements

Special thanks to @Complexlity for identifying this issue and bringing it to attention through issue #4272.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher added this pull request to the merge queue Feb 7, 2024
Merged via the queue into noir-lang:master with commit ed697bb Feb 7, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants