feat: support for external libs (DO NOT MERGE) #5417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…external_libs/noir-edwards subrepo: subdir: "external_libs/noir-edwards" merged: "0016ce82c" upstream: origin: "https://github.com/zac-williamson/noir-edwards.git" branch: "main" commit: "0016ce82c" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "73a0129"
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
# Description ## Problem\* Adds a dummy workflow for the PR #5417 ## Summary\* This will allow the workflow to be run, so that it can be run from the #5417 PR once the dummy version is merged and ran once. ## Additional Context ## Documentation\* Check one: - [X] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
TomAFrench
reviewed
Jul 10, 2024
Co-authored-by: Tom French <[email protected]>
Co-authored-by: Tom French <[email protected]>
|
Closing as I am switching to PR #5485 instead. The new PR uses a Noir repository for the external libs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Add support for external libs
Summary*
Define external libs in a folder of Noir repository as git sub repo.
This PR is a draft and is still WIP. I need a PR to be able to test the CI workflow.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.