Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync from aztec-packages #7241

Merged
merged 21 commits into from
Jan 31, 2025
Merged

feat: Sync from aztec-packages #7241

merged 21 commits into from
Jan 31, 2025
+385 −159

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Jan 30, 2025 •
edited by TomAFrench
Loading

Automated pull of Noir development from aztec-packages.
BEGIN_COMMIT_OVERRIDE
chore(avm): radix opcode - remove immediates (AztecProtocol/aztec-packages#10696)
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 30, 2025
TomAFrench
TomAFrench reviewed Jan 30, 2025
View reviewed changes
noir_stdlib/src/lib.nr Outdated Show resolved Hide resolved
TomAFrench
TomAFrench reviewed Jan 30, 2025
View reviewed changes
noir_stdlib/src/lib.nr Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

🚀 Deployed on https://679befb918cf28561f6acb16--noir-docs.netlify.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

FYI @noir-lang/developerrelations on Noir doc changes.

github-actions[bot]
github-actions bot reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: ca55bbf Previous: 15bbaa8 Ratio
noir-lang_noir_check_shuffle_ 1 s 0 s +∞
noir-lang_eddsa_ 2 s 1 s 2

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@TomAFrench TomAFrench requested a review from aakoshh January 30, 2025 21:02
@TomAFrench
Copy link
Member

@aakoshh This should be ready to be merged now (once #7245 is in).

Can you please break out some issues based on the temp fixes for us to follow up on? We can then merge this.

@github-actions GitHub Actions
Copy link
Contributor

Changes to Brillig bytecode sizes

Generated at commit: bd9054bf7240bf0c484009c1f3c80ba4704f6b1d, compared to commit: 15bbaa86bde37546f69e3e7b375e10b569972bd3

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
missing_closure_env_inliner_zero +16 ❌ +61.54%
closures_mut_ref_inliner_zero +17 ❌ +50.00%
nested_array_dynamic_inliner_max +454 ❌ +23.01%
slice_dynamic_index_inliner_max +377 ❌ +17.76%
slice_dynamic_index_inliner_zero +377 ❌ +17.76%
7_function_inliner_max +82 ❌ +17.19%
regression_6674_1_inliner_max +23 ❌ +12.57%
nested_array_in_slice_inliner_max +118 ❌ +11.64%
regression_6674_2_inliner_max +20 ❌ +10.75%
regression_6674_3_inliner_max +48 ❌ +10.48%
struct_inputs_inliner_max +21 ❌ +8.37%
reference_counts_inliner_max +39 ❌ +8.32%
reference_only_used_as_alias_inliner_min +23 ❌ +7.30%
regression_6674_3_inliner_zero +33 ❌ +6.98%
to_le_bytes_inliner_max +8 ❌ +6.78%
to_le_bytes_inliner_zero +8 ❌ +6.78%
fold_complex_outputs_inliner_zero +30 ❌ +5.69%
global_consts_inliner_max +12 ❌ +5.61%
global_consts_inliner_zero +12 ❌ +5.61%
nested_array_dynamic_inliner_min +99 ❌ +5.33%
nested_array_dynamic_inliner_zero +99 ❌ +5.33%
Full diff report 👇
Program Brillig opcodes (+/-) %
missing_closure_env_inliner_zero 42 (+16) +61.54%
closures_mut_ref_inliner_zero 51 (+17) +50.00%
nested_array_dynamic_inliner_max 2,427 (+454) +23.01%
slice_dynamic_index_inliner_max 2,500 (+377) +17.76%
slice_dynamic_index_inliner_zero 2,500 (+377) +17.76%
7_function_inliner_max 559 (+82) +17.19%
regression_6674_1_inliner_max 206 (+23) +12.57%
nested_array_in_slice_inliner_max 1,132 (+118) +11.64%
regression_6674_2_inliner_max 206 (+20) +10.75%
regression_6674_3_inliner_max 506 (+48) +10.48%
struct_inputs_inliner_max 272 (+21) +8.37%
reference_counts_inliner_max 508 (+39) +8.32%
reference_only_used_as_alias_inliner_min 338 (+23) +7.30%
regression_6674_3_inliner_zero 506 (+33) +6.98%
to_le_bytes_inliner_max 126 (+8) +6.78%
to_le_bytes_inliner_zero 126 (+8) +6.78%
fold_complex_outputs_inliner_zero 557 (+30) +5.69%
global_consts_inliner_max 226 (+12) +5.61%
global_consts_inliner_zero 226 (+12) +5.61%
nested_array_dynamic_inliner_min 1,955 (+99) +5.33%
nested_array_dynamic_inliner_zero 1,955 (+99) +5.33%
global_consts_inliner_min 265 (+12) +4.74%
to_bytes_integration_inliner_max 94 (+4) +4.44%
to_bytes_integration_inliner_zero 94 (+4) +4.44%
higher_order_functions_inliner_max 565 (+24) +4.44%
brillig_cow_inliner_max 371 (+15) +4.21%
to_bits_inliner_min 209 (+8) +3.98%
sha256_var_size_regression_inliner_max 1,724 (+61) +3.67%
to_bytes_integration_inliner_min 231 (+8) +3.59%
conditional_regression_421_inliner_max 88 (+3) +3.53%
conditional_regression_421_inliner_min 88 (+3) +3.53%
conditional_regression_421_inliner_zero 88 (+3) +3.53%
nested_array_in_slice_inliner_min 1,018 (+33) +3.35%
nested_array_in_slice_inliner_zero 1,018 (+33) +3.35%
strings_inliner_max 952 (+30) +3.25%
sha256_brillig_performance_regression_inliner_max 1,667 (+51) +3.16%
slice_regex_inliner_max 2,319 (+69) +3.07%
if_else_chain_inliner_max 106 (+3) +2.91%
if_else_chain_inliner_min 106 (+3) +2.91%
if_else_chain_inliner_zero 106 (+3) +2.91%
slice_regex_inliner_zero 1,704 (+47) +2.84%
hint_black_box_inliner_max 329 (+9) +2.81%
simple_radix_inliner_max 78 (+2) +2.63%
simple_radix_inliner_zero 78 (+2) +2.63%
brillig_rc_regression_6123_inliner_min 236 (+6) +2.61%
higher_order_functions_inliner_zero 735 (+18) +2.51%
to_bytes_consistent_inliner_min 83 (+2) +2.47%
to_bytes_consistent_inliner_zero 83 (+2) +2.47%
slice_loop_inliner_max 252 (+6) +2.44%
side_effects_constrain_array_inliner_min 127 (+3) +2.42%
side_effects_constrain_array_inliner_zero 127 (+3) +2.42%
to_le_bytes_inliner_min 171 (+4) +2.40%
struct_inputs_inliner_zero 257 (+6) +2.39%
6_array_inliner_max 386 (+9) +2.39%
conditional_regression_661_inliner_max 129 (+3) +2.38%
array_to_slice_inliner_max 702 (+16) +2.33%
hash_to_field_inliner_min 221 (+5) +2.31%
regression_struct_array_conditional_inliner_max 546 (+12) +2.25%
regression_struct_array_conditional_inliner_min 546 (+12) +2.25%
simple_radix_inliner_min 91 (+2) +2.25%
regression_struct_array_conditional_inliner_zero 546 (+12) +2.25%
aes128_encrypt_inliner_max 420 (+9) +2.19%
blake3_inliner_max 143 (+3) +2.14%
7_inliner_max 143 (+3) +2.14%
7_inliner_zero 143 (+3) +2.14%
blake3_inliner_zero 143 (+3) +2.14%
sha256_var_witness_const_regression_inliner_max 1,274 (+26) +2.08%
6_array_inliner_zero 445 (+9) +2.06%
array_len_inliner_max 100 (+2) +2.04%
array_len_inliner_zero 100 (+2) +2.04%
sha256_brillig_performance_regression_inliner_zero 1,707 (+34) +2.03%
6_array_inliner_min 455 (+9) +2.02%
sha256_inliner_max 2,333 (+45) +1.97%
slice_loop_inliner_zero 320 (+6) +1.91%
conditional_regression_661_inliner_zero 161 (+3) +1.90%
slice_loop_inliner_min 333 (+6) +1.83%
conditional_regression_661_inliner_min 167 (+3) +1.83%
brillig_rc_regression_6123_inliner_max 169 (+3) +1.81%
brillig_rc_regression_6123_inliner_zero 169 (+3) +1.81%
brillig_cow_regression_inliner_max 2,088 (+37) +1.80%
array_len_inliner_min 113 (+2) +1.80%
6_inliner_max 1,155 (+19) +1.67%
hint_black_box_inliner_zero 372 (+6) +1.64%
sha256_var_padding_regression_inliner_max 4,984 (+80) +1.63%
brillig_cow_regression_inliner_zero 2,123 (+34) +1.63%
regression_7128_inliner_max 127 (+2) +1.60%
regression_7128_inliner_zero 127 (+2) +1.60%
hint_black_box_inliner_min 383 (+6) +1.59%
brillig_cow_regression_inliner_min 2,379 (+37) +1.58%
conditional_regression_short_circuit_inliner_max 1,228 (+19) +1.57%
to_bytes_consistent_inliner_max 133 (+2) +1.53%
regression_4449_inliner_max 737 (+11) +1.52%
ram_blowup_regression_inliner_max 942 (+14) +1.51%
hash_to_field_inliner_max 137 (+2) +1.48%
hash_to_field_inliner_zero 137 (+2) +1.48%
u128_inliner_max 2,696 (+38) +1.43%
array_to_slice_inliner_min 1,018 (+14) +1.39%
sha256_var_padding_regression_inliner_zero 2,968 (+40) +1.37%
uhashmap_inliner_max 12,728 (+170) +1.35%
higher_order_functions_inliner_min 1,355 (+18) +1.35%
regression_7128_inliner_min 151 (+2) +1.34%
strings_inliner_zero 937 (+12) +1.30%
array_dynamic_nested_blackbox_input_inliner_max 868 (+11) +1.28%
ecdsa_secp256k1_inliner_max 891 (+11) +1.25%
conditional_1_inliner_max 1,146 (+14) +1.24%
sha256_inliner_zero 1,249 (+15) +1.22%
u128_inliner_zero 1,980 (+23) +1.18%
sha256_regression_inliner_max 6,761 (+78) +1.17%
array_dedup_regression_inliner_max 261 (+3) +1.16%
array_dedup_regression_inliner_zero 261 (+3) +1.16%
merkle_insert_inliner_max 705 (+8) +1.15%
array_dedup_regression_inliner_min 268 (+3) +1.13%
regression_5252_inliner_zero 3,395 (+38) +1.13%
wildcard_type_inliner_max 281 (+3) +1.08%
wildcard_type_inliner_zero 281 (+3) +1.08%
ram_blowup_regression_inliner_zero 955 (+10) +1.06%
sha256_var_size_regression_inliner_min 1,258 (+13) +1.04%
wildcard_type_inliner_min 292 (+3) +1.04%
sha256_var_witness_const_regression_inliner_zero 811 (+8) +1.00%
to_be_bytes_inliner_max 204 (+2) +0.99%
to_be_bytes_inliner_zero 204 (+2) +0.99%
u128_inliner_min 2,285 (+22) +0.97%
regression_bignum_inliner_max 316 (+3) +0.96%
regression_bignum_inliner_zero 316 (+3) +0.96%
6_inliner_zero 843 (+8) +0.96%
keccak256_inliner_max 2,108 (+20) +0.96%
array_dynamic_blackbox_input_inliner_max 846 (+8) +0.95%
fold_numeric_generic_poseidon_inliner_min 641 (+6) +0.94%
no_predicates_numeric_generic_poseidon_inliner_min 641 (+6) +0.94%
array_to_slice_inliner_zero 750 (+7) +0.94%
sha2_byte_inliner_max 2,122 (+19) +0.90%
to_be_bytes_inliner_min 230 (+2) +0.88%
conditional_regression_short_circuit_inliner_zero 925 (+8) +0.87%
sha256_var_padding_regression_inliner_min 3,244 (+28) +0.87%
poseidonsponge_x5_254_inliner_zero 3,020 (+26) +0.87%
poseidon_bn254_hash_inliner_zero 4,702 (+38) +0.81%
poseidon_bn254_hash_width_3_inliner_zero 4,702 (+38) +0.81%
slices_inliner_max 2,132 (+17) +0.80%
ram_blowup_regression_inliner_min 1,148 (+9) +0.79%
array_dynamic_blackbox_input_inliner_zero 1,032 (+8) +0.78%
aes128_encrypt_inliner_zero 391 (+3) +0.77%
fold_2_to_17_inliner_max 562 (+4) +0.72%
aes128_encrypt_inliner_min 437 (+3) +0.69%
hashmap_inliner_zero 7,888 (+53) +0.68%
bigint_inliner_max 2,106 (+14) +0.67%
sha256_regression_inliner_zero 4,880 (+32) +0.66%
regression_4449_inliner_zero 774 (+5) +0.65%
sha256_brillig_performance_regression_inliner_min 1,859 (+12) +0.65%
regression_inliner_max 932 (+6) +0.65%
sha256_var_size_regression_inliner_zero 1,102 (+7) +0.64%
uhashmap_inliner_zero 7,515 (+47) +0.63%
regression_inliner_zero 969 (+6) +0.62%
sha2_byte_inliner_zero 2,222 (+13) +0.59%
sha256_regression_inliner_min 5,318 (+31) +0.59%
array_dynamic_nested_blackbox_input_inliner_zero 895 (+5) +0.56%
slices_inliner_min 2,537 (+14) +0.55%
ecdsa_secp256k1_inliner_zero 918 (+5) +0.55%
hashmap_inliner_max 19,766 (+103) +0.52%
regression_5252_inliner_max 4,456 (+23) +0.52%
poseidon_bn254_hash_inliner_min 5,048 (+26) +0.52%
poseidon_bn254_hash_width_3_inliner_min 5,048 (+26) +0.52%
sha256_inliner_min 1,402 (+7) +0.50%
conditional_1_inliner_min 1,427 (+7) +0.49%
regression_5252_inliner_min 3,588 (+17) +0.48%
reference_counts_inliner_zero 666 (+3) +0.45%
conditional_1_inliner_zero 1,126 (+5) +0.45%
poseidonsponge_x5_254_inliner_min 3,168 (+14) +0.44%
merkle_insert_inliner_zero 465 (+2) +0.43%
bigint_inliner_zero 1,878 (+8) +0.43%
slice_regex_inliner_min 2,127 (+9) +0.42%
merkle_insert_inliner_min 496 (+2) +0.40%
sha256_var_witness_const_regression_inliner_min 994 (+4) +0.40%
bigint_inliner_min 1,996 (+8) +0.40%
hashmap_inliner_min 9,830 (+39) +0.40%
6_inliner_min 1,020 (+4) +0.39%
7_function_inliner_zero 520 (+2) +0.39%
slices_inliner_zero 2,092 (+8) +0.38%
regression_4449_inliner_min 1,076 (+4) +0.37%
uhashmap_inliner_min 8,360 (+30) +0.36%
conditional_regression_short_circuit_inliner_min 1,121 (+4) +0.36%
array_dynamic_nested_blackbox_input_inliner_min 1,210 (+4) +0.33%
ecdsa_secp256k1_inliner_min 1,223 (+4) +0.33%
array_dynamic_blackbox_input_inliner_min 1,285 (+4) +0.31%
7_function_inliner_min 650 (+2) +0.31%
keccak256_inliner_min 1,673 (+5) +0.30%
simple_shield_inliner_zero 722 (+2) +0.28%
poseidonsponge_x5_254_inliner_max 4,116 (+11) +0.27%
sha2_byte_inliner_min 3,006 (+8) +0.27%
keccak256_inliner_zero 1,975 (+5) +0.25%
simple_shield_inliner_max 826 (+2) +0.24%
simple_shield_inliner_min 863 (+2) +0.23%
poseidon_bn254_hash_width_3_inliner_max 5,273 (+5) +0.09%
poseidon_bn254_hash_inliner_max 5,273 (+5) +0.09%

@github-actions GitHub Actions
Copy link
Contributor

Changes to number of Brillig opcodes executed

Generated at commit: bd9054bf7240bf0c484009c1f3c80ba4704f6b1d, compared to commit: 15bbaa86bde37546f69e3e7b375e10b569972bd3

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
missing_closure_env_inliner_zero +12 ❌ +54.55%
closures_mut_ref_inliner_zero +13 ❌ +38.24%
nested_array_dynamic_inliner_max +397 ❌ +13.20%
reference_counts_inliner_max +39 ❌ +9.77%
slice_dynamic_index_inliner_max +408 ❌ +9.60%
slice_dynamic_index_inliner_zero +408 ❌ +9.60%
7_function_inliner_max +160 ❌ +7.77%
nested_array_in_slice_inliner_max +76 ❌ +5.48%
regression_4449_inliner_max +10,503 ❌ +5.48%
reference_only_used_as_alias_inliner_min +23 ❌ +4.84%
6_inliner_max +303 ❌ +4.57%
conditional_regression_short_circuit_inliner_max +303 ❌ +4.51%
struct_inputs_inliner_max +21 ❌ +3.83%
array_dynamic_nested_blackbox_input_inliner_max +153 ❌ +3.73%
sha256_inliner_max +484 ❌ +3.67%
regression_6674_3_inliner_max +48 ❌ +3.54%
conditional_regression_421_inliner_max +3 ❌ +3.30%
conditional_regression_421_inliner_min +3 ❌ +3.30%
conditional_regression_421_inliner_zero +3 ❌ +3.30%
fold_complex_outputs_inliner_zero +30 ❌ +3.28%
regression_6674_1_inliner_max +19 ❌ +3.22%
Full diff report 👇
Program Brillig opcodes (+/-) %
missing_closure_env_inliner_zero 34 (+12) +54.55%
closures_mut_ref_inliner_zero 47 (+13) +38.24%
nested_array_dynamic_inliner_max 3,405 (+397) +13.20%
reference_counts_inliner_max 438 (+39) +9.77%
slice_dynamic_index_inliner_max 4,656 (+408) +9.60%
slice_dynamic_index_inliner_zero 4,656 (+408) +9.60%
7_function_inliner_max 2,219 (+160) +7.77%
nested_array_in_slice_inliner_max 1,462 (+76) +5.48%
regression_4449_inliner_max 202,335 (+10,503) +5.48%
reference_only_used_as_alias_inliner_min 498 (+23) +4.84%
6_inliner_max 6,937 (+303) +4.57%
conditional_regression_short_circuit_inliner_max 7,015 (+303) +4.51%
struct_inputs_inliner_max 569 (+21) +3.83%
array_dynamic_nested_blackbox_input_inliner_max 4,260 (+153) +3.73%
sha256_inliner_max 13,682 (+484) +3.67%
regression_6674_3_inliner_max 1,403 (+48) +3.54%
conditional_regression_421_inliner_max 94 (+3) +3.30%
conditional_regression_421_inliner_min 94 (+3) +3.30%
conditional_regression_421_inliner_zero 94 (+3) +3.30%
fold_complex_outputs_inliner_zero 944 (+30) +3.28%
regression_6674_1_inliner_max 609 (+19) +3.22%
conditional_1_inliner_max 5,104 (+156) +3.15%
if_else_chain_inliner_max 103 (+3) +3.00%
if_else_chain_inliner_min 103 (+3) +3.00%
if_else_chain_inliner_zero 103 (+3) +3.00%
sha256_var_witness_const_regression_inliner_max 6,449 (+181) +2.89%
slice_regex_inliner_zero 4,059 (+113) +2.86%
simple_radix_inliner_max 73 (+2) +2.82%
simple_radix_inliner_zero 73 (+2) +2.82%
wildcard_type_inliner_max 445 (+12) +2.77%
wildcard_type_inliner_zero 445 (+12) +2.77%
higher_order_functions_inliner_max 907 (+24) +2.72%
regression_6674_2_inliner_max 609 (+16) +2.70%
wildcard_type_inliner_min 460 (+12) +2.68%
conditional_regression_661_inliner_max 122 (+3) +2.52%
brillig_rc_regression_6123_inliner_min 368 (+9) +2.51%
ecdsa_secp256k1_inliner_max 6,439 (+153) +2.43%
regression_6674_3_inliner_zero 1,403 (+33) +2.41%
simple_radix_inliner_min 90 (+2) +2.27%
nested_array_dynamic_inliner_min 3,613 (+78) +2.21%
nested_array_dynamic_inliner_zero 3,613 (+78) +2.21%
side_effects_constrain_array_inliner_min 139 (+3) +2.21%
side_effects_constrain_array_inliner_zero 139 (+3) +2.21%
slice_regex_inliner_max 3,253 (+69) +2.17%
struct_inputs_inliner_zero 604 (+12) +2.03%
conditional_regression_661_inliner_zero 152 (+3) +2.01%
conditional_regression_661_inliner_min 168 (+3) +1.82%
strings_inliner_max 1,746 (+30) +1.75%
array_dynamic_blackbox_input_inliner_max 17,529 (+300) +1.74%
sha256_var_size_regression_inliner_max 15,726 (+223) +1.44%
brillig_cow_inliner_max 1,097 (+15) +1.39%
6_array_inliner_max 1,537 (+21) +1.39%
higher_order_functions_inliner_zero 1,334 (+18) +1.37%
hint_black_box_inliner_max 675 (+9) +1.35%
nested_array_in_slice_inliner_min 1,742 (+21) +1.22%
nested_array_in_slice_inliner_zero 1,742 (+21) +1.22%
strings_inliner_zero 2,101 (+24) +1.16%
fold_numeric_generic_poseidon_inliner_min 5,858 (+66) +1.14%
no_predicates_numeric_generic_poseidon_inliner_min 5,858 (+66) +1.14%
to_bits_inliner_min 744 (+8) +1.09%
array_len_inliner_max 191 (+2) +1.06%
array_len_inliner_zero 191 (+2) +1.06%
brillig_rc_regression_6123_inliner_max 288 (+3) +1.05%
brillig_rc_regression_6123_inliner_zero 288 (+3) +1.05%
array_to_slice_inliner_max 1,637 (+16) +0.99%
array_len_inliner_min 208 (+2) +0.97%
hint_black_box_inliner_zero 1,006 (+9) +0.90%
hint_black_box_inliner_min 1,021 (+9) +0.89%
6_array_inliner_zero 2,491 (+21) +0.85%
6_array_inliner_min 2,561 (+21) +0.83%
higher_order_functions_inliner_min 2,291 (+18) +0.79%
global_consts_inliner_max 1,623 (+12) +0.74%
global_consts_inliner_zero 1,623 (+12) +0.74%
global_consts_inliner_min 1,709 (+12) +0.71%
slice_loop_inliner_max 901 (+6) +0.67%
slice_regex_inliner_min 8,637 (+57) +0.66%
sha256_inliner_zero 11,430 (+72) +0.63%
array_to_slice_inliner_min 2,261 (+14) +0.62%
regression_bignum_inliner_max 490 (+3) +0.62%
regression_bignum_inliner_zero 490 (+3) +0.62%
sha256_var_witness_const_regression_inliner_zero 7,001 (+42) +0.60%
to_bytes_consistent_inliner_min 669 (+4) +0.60%
to_bytes_consistent_inliner_zero 669 (+4) +0.60%
slices_inliner_max 3,276 (+17) +0.52%
hash_to_field_inliner_min 973 (+5) +0.52%
sha256_inliner_min 12,366 (+63) +0.51%
regression_4449_inliner_zero 228,377 (+1,123) +0.49%
slice_loop_inliner_zero 1,273 (+6) +0.47%
6_inliner_zero 4,461 (+21) +0.47%
regression_4449_inliner_min 269,603 (+1,260) +0.47%
slice_loop_inliner_min 1,290 (+6) +0.47%
conditional_regression_short_circuit_inliner_zero 4,541 (+21) +0.46%
sha256_var_witness_const_regression_inliner_min 7,794 (+36) +0.46%
to_le_bytes_inliner_max 1,097 (+5) +0.46%
to_le_bytes_inliner_zero 1,097 (+5) +0.46%
array_dedup_regression_inliner_max 672 (+3) +0.45%
array_dedup_regression_inliner_zero 672 (+3) +0.45%
sha256_regression_inliner_max 112,130 (+490) +0.44%
array_dynamic_nested_blackbox_input_inliner_zero 4,512 (+19) +0.42%
reference_counts_inliner_zero 724 (+3) +0.42%
regression_struct_array_conditional_inliner_max 1,471 (+6) +0.41%
regression_struct_array_conditional_inliner_min 1,471 (+6) +0.41%
regression_struct_array_conditional_inliner_zero 1,471 (+6) +0.41%
sha2_byte_inliner_max 44,107 (+175) +0.40%
6_inliner_min 4,874 (+18) +0.37%
array_dynamic_nested_blackbox_input_inliner_min 4,966 (+18) +0.36%
conditional_regression_short_circuit_inliner_min 4,980 (+18) +0.36%
array_to_slice_inliner_zero 1,965 (+7) +0.36%
conditional_1_inliner_min 5,999 (+21) +0.35%
conditional_1_inliner_zero 5,530 (+19) +0.34%
sha256_brillig_performance_regression_inliner_max 22,027 (+74) +0.34%
slices_inliner_min 4,292 (+14) +0.33%
aes128_encrypt_inliner_max 2,879 (+9) +0.31%
uhashmap_inliner_max 137,520 (+415) +0.30%
to_bytes_consistent_inliner_max 696 (+2) +0.29%
7_inliner_max 1,047 (+3) +0.29%
blake3_inliner_max 1,047 (+3) +0.29%
7_inliner_zero 1,047 (+3) +0.29%
blake3_inliner_zero 1,047 (+3) +0.29%
sha256_brillig_performance_regression_inliner_zero 26,519 (+71) +0.27%
ecdsa_secp256k1_inliner_zero 7,631 (+19) +0.25%
array_dedup_regression_inliner_min 1,235 (+3) +0.24%
to_bytes_integration_inliner_min 4,251 (+10) +0.24%
merkle_insert_inliner_max 3,503 (+8) +0.23%
hash_to_field_inliner_max 880 (+2) +0.23%
hash_to_field_inliner_zero 880 (+2) +0.23%
sha256_regression_inliner_zero 155,674 (+351) +0.23%
regression_inliner_max 2,674 (+6) +0.22%
slices_inliner_zero 3,602 (+8) +0.22%
regression_inliner_zero 2,720 (+6) +0.22%
ecdsa_secp256k1_inliner_min 8,210 (+18) +0.22%
sha256_var_size_regression_inliner_min 22,188 (+48) +0.22%
sha256_var_size_regression_inliner_zero 21,433 (+42) +0.20%
hashmap_inliner_max 48,381 (+94) +0.19%
to_bytes_integration_inliner_max 2,071 (+4) +0.19%
to_bytes_integration_inliner_zero 2,071 (+4) +0.19%
array_dynamic_blackbox_input_inliner_zero 21,311 (+41) +0.19%
sha256_brillig_performance_regression_inliner_min 26,900 (+49) +0.18%
to_le_bytes_inliner_min 1,127 (+2) +0.18%
regression_7128_inliner_max 1,189 (+2) +0.17%
regression_7128_inliner_zero 1,189 (+2) +0.17%
regression_7128_inliner_min 1,221 (+2) +0.16%
array_dynamic_blackbox_input_inliner_min 22,398 (+36) +0.16%
poseidon_bn254_hash_inliner_zero 182,485 (+270) +0.15%
poseidon_bn254_hash_width_3_inliner_zero 182,485 (+270) +0.15%
sha256_var_padding_regression_inliner_max 196,948 (+284) +0.14%
keccak256_inliner_max 30,664 (+44) +0.14%
sha256_regression_inliner_min 157,716 (+222) +0.14%
u128_inliner_max 24,283 (+34) +0.14%
uhashmap_inliner_zero 175,378 (+245) +0.14%
poseidon_bn254_hash_inliner_min 185,973 (+258) +0.14%
poseidon_bn254_hash_width_3_inliner_min 185,973 (+258) +0.14%
brillig_cow_regression_inliner_max 455,393 (+631) +0.14%
poseidonsponge_x5_254_inliner_zero 202,266 (+276) +0.14%
regression_5252_inliner_zero 1,008,357 (+1,368) +0.14%
ram_blowup_regression_inliner_max 684,186 (+919) +0.13%
regression_5252_inliner_min 1,032,599 (+1,329) +0.13%
poseidonsponge_x5_254_inliner_min 206,589 (+264) +0.13%
merkle_insert_inliner_min 3,426 (+4) +0.12%
brillig_cow_regression_inliner_zero 541,026 (+628) +0.12%
brillig_cow_regression_inliner_min 544,623 (+631) +0.12%
ram_blowup_regression_inliner_zero 815,441 (+915) +0.11%
ram_blowup_regression_inliner_min 819,699 (+914) +0.11%
keccak256_inliner_zero 31,724 (+35) +0.11%
merkle_insert_inliner_zero 3,638 (+4) +0.11%
keccak256_inliner_min 32,105 (+35) +0.11%
sha256_var_padding_regression_inliner_zero 230,647 (+240) +0.10%
hashmap_inliner_zero 74,676 (+74) +0.10%
sha256_var_padding_regression_inliner_min 232,146 (+228) +0.10%
aes128_encrypt_inliner_zero 3,078 (+3) +0.10%
to_be_bytes_inliner_max 2,096 (+2) +0.10%
to_be_bytes_inliner_zero 2,096 (+2) +0.10%
to_be_bytes_inliner_min 2,130 (+2) +0.09%
uhashmap_inliner_min 197,161 (+180) +0.09%
aes128_encrypt_inliner_min 3,485 (+3) +0.09%
7_function_inliner_zero 2,441 (+2) +0.08%
simple_shield_inliner_zero 2,496 (+2) +0.08%
simple_shield_inliner_max 2,512 (+2) +0.08%
simple_shield_inliner_min 2,581 (+2) +0.08%
7_function_inliner_min 2,624 (+2) +0.08%
u128_inliner_zero 40,973 (+29) +0.07%
hashmap_inliner_min 90,422 (+60) +0.07%
u128_inliner_min 48,513 (+30) +0.06%
sha2_byte_inliner_zero 72,369 (+41) +0.06%
sha2_byte_inliner_min 89,471 (+36) +0.04%
regression_5252_inliner_max 854,221 (+79) +0.01%
poseidonsponge_x5_254_inliner_max 171,526 (+11) +0.01%
poseidon_bn254_hash_inliner_max 151,739 (+5) +0.00%
poseidon_bn254_hash_width_3_inliner_max 151,739 (+5) +0.00%
fold_2_to_17_inliner_max 1,056,633 (+4) +0.00%
verify_honk_proof_inliner_max 4,190 (-28) -0.66%
verify_honk_proof_inliner_min 4,190 (-28) -0.66%
verify_honk_proof_inliner_zero 4,190 (-28) -0.66%
double_verify_honk_proof_inliner_max 7,421 (-56) -0.75%
double_verify_honk_proof_inliner_min 7,421 (-56) -0.75%
double_verify_honk_proof_inliner_zero 7,421 (-56) -0.75%

@TomAFrench
Copy link
Member

Merging as Akosh is out today.

This was referenced Jan 31, 2025
Open
Open
Open
@TomAFrench TomAFrench added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit a2a0478 Jan 31, 2025
102 checks passed
@TomAFrench TomAFrench deleted the aztec-packages branch January 31, 2025 12:47
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 31, 2025
@AztecBot
[1 changes] feat: Sync from aztec-packages (noir-lang/noir#7241)
ce561cb 
chore: bump gates diff (noir-lang/noir#7245)
feat: simplify subtraction from self to return zero (noir-lang/noir#7189)
feat: allow specifying multiple patterns in nargo test (noir-lang/noir#7186)
fix: Avoid type error when calling something with a type alias of a function (noir-lang/noir#7239)
feat: Allow resolved types in constructors (noir-lang/noir#7223)
chore: clarify to_radix docs examples (noir-lang/noir#7230)
chore: fix struct example (noir-lang/noir#7198)
feat(optimization): Add purity analysis to SSA (noir-lang/noir#7197)
chore: start tracking time to run critical library tests (noir-lang/noir#7221)
chore: Rework defunctionalize pass to not rely on DFG bugs (noir-lang/noir#7222)
fix(brillig): Globals entry point reachability analysis  (noir-lang/noir#7188)
chore: update docs to use devcontainer feature (noir-lang/noir#7206)
chore(ci): Add test for global vars entry points regression (noir-lang/noir#7209)
chore(ssa): Flip the SSA Brillig constraint check to off by default (noir-lang/noir#7211)
chore(docs): moving references to noir-starter to awesome-noir (noir-lang/noir#7203)
chore: build docs in the merge queue (noir-lang/noir#7218)
fix: correct reversed callstacks (noir-lang/noir#7212)
chore: exclude dependency fetching time from benchmarks (noir-lang/noir#7210)
feat(experimental): Support enums in comptime code (noir-lang/noir#7194)
@AztecBot AztecBot mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@TomAFrench TomAFrench TomAFrench approved these changes

@aakoshh aakoshh Awaiting requested review from aakoshh

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AztecBot @TomAFrench