Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let all compiler errors carry a Location instead of a Span #7486

Merged
merged 18 commits into from
Feb 25, 2025
Merged

feat: let all compiler errors carry a Location instead of a Span #7486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9fe78e2
Let all compiler errors carry a Location instead of a Span
asterite Feb 21, 2025
5128c92
Keep track of Path kind location
asterite Feb 21, 2025
ec04364
Keep track of where the unsafe keyword is
asterite Feb 21, 2025
f732789
All errors now have a `location` method
asterite Feb 21, 2025
5eabc65
No need to keep track of FileId when CompileError has a Location
asterite Feb 21, 2025
0ee0ef1
Let `push_stmt_location` take a Location
asterite Feb 21, 2025
5fbb4ad
No need for Elaborator to keep track of a file anymore
asterite Feb 21, 2025
dbe9cb7
Fix a TODO
asterite Feb 21, 2025
31ccec7
Merge branch 'master' into ab/compiler-diagnostic-location
asterite Feb 21, 2025
f4e8904
Introduce UnsafeExpression
asterite Feb 23, 2025
5fcefe3
UnsafeExpression::location seems to be unused
asterite Feb 23, 2025
812c17f
Merge two errors now that we can have multiple locations in an error
asterite Feb 23, 2025
87134d9
Merge branch 'master' into ab/compiler-diagnostic-location
asterite Feb 23, 2025
a64e911
Update compiler/noirc_frontend/src/elaborator/comptime.rs
jfecher Feb 24, 2025
94eca5e
Update compiler/noirc_frontend/src/elaborator/types.rs
jfecher Feb 24, 2025
163ec2c
Bump memory limit for private-kernel-tail
asterite Feb 24, 2025
845293e
Merge branch 'master' into ab/compiler-diagnostic-location
asterite Feb 24, 2025
9f59e82
Merge branch 'master' into ab/compiler-diagnostic-location
asterite Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/benchmark_projects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ projects:
compilation-timeout: 1.2
execution-timeout: 0.02
compilation-memory-limit: 250
execution-memory-limit: 200
execution-memory-limit: 210
private-kernel-reset:
repo: AztecProtocol/aztec-packages
ref: *AZ_COMMIT
Expand Down
Loading
Loading