fix(experimental): Replace most remaining match panics with errors #7536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Feb 26, 2025
chore: revert bump of base64ct to `v1.6.0` after `v1.7.0` yanked (noir-lang/noir#7541) feat(performance): Avoid extra Brillig array offsetting for constant indices (noir-lang/noir#7522) feat: test error spans and messages (noir-lang/noir#7526) chore: bump wasm-bindgen (noir-lang/noir#7535) chore: parallelize `test_transform_program_is_idempotent` (noir-lang/noir#7539) chore(cli): Use `noir_artifact_cli::fs` to read artifacts (noir-lang/noir#7391) fix(experimental): Replace most remaining match panics with errors (noir-lang/noir#7536) chore: bump external pinned commits (noir-lang/noir#7537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Replaces most remaining panic/println cases in the match compiler with friendly user errors.
The only two remaining errors are what I consider to be the meatier ones: redundant cases & unhandled cases since these require more analysis of the match tree itself. The later also typically requires constructing an example of a value that wouldn't be matched as part of the error message.
Additional Context
I've moved the frontend tests which deal with enums & matches to a new
tests/enums.rsfile since the frontend tests file is quite large. I'll add a comment noting where the new tests in this file are - the old ones are unchanged.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.