Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove FileDiagnostic #7546

Merged
merged 2 commits into from
Feb 27, 2025
Merged

chore: remove FileDiagnostic #7546

merged 2 commits into from
Feb 27, 2025

Conversation

asterite
Copy link
Collaborator

Description

Problem

Addresses this comment: #7486 (comment)

Summary

Now that CustomDiagnostic almost always carries a Location, I change it to also always carry a file: FileId so that we no longer need an extra FileDiagnostic type, and code becomes a bit simpler.

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested a review from a team February 27, 2025 13:20
jfecher
jfecher approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for being on top of this

@jfecher jfecher added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit 3a4e070 Feb 27, 2025
102 checks passed
@jfecher jfecher deleted the ab/remove-file-diagnostic branch February 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asterite @jfecher