chore: remove witness flag from nargo compile
#878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
remove-generate-witness
branch
from
0181c61 to
0c62c13
Compare
kevaundray
approved these changes
Feb 20, 2023
|
+1 for the analogy in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #877
Description
Summary of changes
This PR removes the ability to save a witness to file from the
nargo compilecommand. This should instead be done through thenargo executecommand for reasons stated in the issue.Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Additional context