Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Document name resolution #925

Merged
merged 3 commits into from
Feb 28, 2023
Merged

chore: Document name resolution #925

merged 3 commits into from
Feb 28, 2023

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Feb 27, 2023

Related issue(s)

(None)

Description

Summary of changes

Adds documentation to various items in the name resolution pass.

Documents some higher-level architecture of the pass, most notably that it has two phases: the definition collection phase, followed by the actual name resolution phase.

@jfecher jfecher changed the title Document name resolution chore: Document name resolution Feb 27, 2023
@kevaundray kevaundray self-requested a review February 27, 2023 20:47
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Weird that clippy has now started to fail

@jfecher jfecher enabled auto-merge February 27, 2023 21:45
@TomAFrench
Copy link
Member

LGTM. Weird that clippy has now started to fail

We've started enforcing clippy on all crates in the workspace as previously it was only enforcing it on nargo. This warning is fixed in #918 so we just need to merge master back into this branch.

@jfecher jfecher added this pull request to the merge queue Feb 27, 2023
Merged via the queue into master with commit 007ab75 Feb 28, 2023
@jfecher jfecher deleted the jf/hir-docs branch February 28, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants