Update to classic charms to build using charmcraft in CI

This update is to ensure that the Zuul Canonical CI builds the charm
before functional tests and ensure that that artifact is used for the
functional tests.  This is to try to ensure that the charm that gets
landed to the charmhub is the same charm that was tested with.

Change-Id: I0febbbf7da990026b9578a3512c99539eb03bbc0

build-requirements.txt

@@ -0,0 +1,7 @@
+# NOTES(lourot):
+# * We don't install charmcraft via pip anymore because it anyway spins up a
+#   container and scp the system's charmcraft snap inside it. So the charmcraft
+#   snap is necessary on the system anyway.
+# * `tox -e build` successfully validated with charmcraft 1.2.1
+
+cffi==1.14.6; python_version < '3.6'  # cffi 1.15.0 drops support for py35.

charmcraft.yaml

@@ -6,6 +6,7 @@ parts:
     source: .
     prime:
       - actions/*
+      - charmhelpers/*
       - files/*
       - hooks/*
       - lib/*

osci.yaml

@@ -4,3 +4,7 @@
       - charm-unit-jobs-py39
       - charm-xena-functional-jobs
       - charm-yoga-functional-jobs
+    vars:
+      needs_charm_build: true
+      charm_build_name: neutron-api
+      build_type: charmcraft

rename.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+charm=$(grep "charm_build_name" osci.yaml | awk '{print $2}')
+echo "renaming ${charm}_*.charm to ${charm}.charm"
+echo -n "pwd: "
+pwd
+ls -al
+echo "Removing bad downloaded charm maybe?"
+if [[ -e "${charm}.charm" ]];
+then
+    rm "${charm}.charm"
+fi
+echo "Renaming charm here."
+mv ${charm}_*.charm ${charm}.charm

tests/bundles/focal-xena.yaml

@@ -23,7 +23,7 @@ applications:
       source: *openstack-origin
     channel: latest/edge
   neutron-api:
-    charm: ../../
+    charm: ../../neutron-api.charm
     num_units: 1
     options:
       manage-neutron-plugin-legacy-mode: True

tests/bundles/focal-yoga.yaml

@@ -23,7 +23,7 @@ applications:
       source: *openstack-origin
     channel: latest/edge
   neutron-api:
-    charm: ../../
+    charm: ../../neutron-api.charm
     num_units: 1
     options:
       manage-neutron-plugin-legacy-mode: True

tests/bundles/impish-xena.yaml

@@ -23,7 +23,7 @@ applications:
       source: *openstack-origin
     channel: latest/edge
   neutron-api:
-    charm: ../../
+    charm: ../../neutron-api.charm
     num_units: 1
     options:
       manage-neutron-plugin-legacy-mode: True

tests/bundles/jammy-yoga.yaml

@@ -23,7 +23,7 @@ applications:
       source: *openstack-origin
     channel: latest/edge
   neutron-api:
-    charm: ../../
+    charm: ../../neutron-api.charm
     num_units: 1
     options:
       manage-neutron-plugin-legacy-mode: True

tox.ini

@@ -37,10 +37,20 @@ setenv = VIRTUAL_ENV={envdir}
 install_command =
   {toxinidir}/pip.sh install {opts} {packages}
 commands = stestr run --slowest {posargs}
-allowlist_externals = juju
+allowlist_externals =
+    charmcraft
+    rename.sh
 passenv = HOME TERM CS_* OS_* TEST_*
 deps = -r{toxinidir}/test-requirements.txt
 
+[testenv:build]
+basepython = python3
+deps = -r{toxinidir}/build-requirements.txt
+commands =
+    charmcraft clean
+    charmcraft -v build
+    {toxinidir}/rename.sh
+
 [testenv:py35]
 basepython = python3.5
 deps = -r{toxinidir}/requirements.txt