Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: navigation, pagination, scrollbar props #4181 #4182

Merged
merged 3 commits into from
Feb 3, 2021

Conversation

mya-ake
Copy link
Contributor

@mya-ake mya-ake commented Feb 2, 2021

fix: #4181

In the case of {}, needsNavigation, needsPagination, and needsScrollbar will be true, so if each props is false, the initial value is given so that element is null.

@vltansky
Copy link
Collaborator

vltansky commented Feb 2, 2021

You can contribute to vue & svelte versions with the same change.

Take a look at src/svelte/get-params.js and src/vue/get-params.js

@mya-ake
Copy link
Contributor Author

mya-ake commented Feb 3, 2021

I also updated svelte and vue.

@vltansky vltansky requested a review from nolimits4web February 3, 2021 08:13
@nolimits4web nolimits4web merged commit c990909 into nolimits4web:master Feb 3, 2021
@nolimits4web
Copy link
Owner

Merged, thanks! Checked and everything seems fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not disabled when props of navigation, pagination and scrollbar are false
3 participants