fix: use find where possible instead of filter #7815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you! Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love swiper! This project is super fast. I'm using this in a calendar project which has multiple swipers on one page. I'm facing some performance issues on slow mobile phones and I'm trying to figure out ways to help out and make this library even more performant.
I found this previous similar PR which was not merged. I guess it had too many changes. I tried to keep this small and concise as possible so it's easy to see what changed.
I think swapping filter out for find should bring some performance gains and is quite safe thing to do.
I will keep looking for ways to increase performance of this awesome project.