Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add needed apis for multi delivery et al. #11

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

add needed apis for multi delivery et al. #11

wants to merge 18 commits into from

Conversation

Warry
Copy link

@Warry Warry commented Jan 3, 2023

Formats related types stand in their own file.

@Warry Warry force-pushed the multi-things branch 2 times, most recently from 0207a4d to 4875fe3 Compare January 3, 2023 17:15
@Warry Warry requested review from sebcreme and Giska January 3, 2023 17:16
timecode?: string;
}

export interface FileLike {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FileLike ? Je vois pas trop a quoi ca correspond c'est pas juste le type du fichier ?

headers.append("Cookie", setCookie);
}

const setCookie = getSetCookies(response.headers)[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est pas un peu dangereux de mettre que le premier sans vérifier ce que c'est ? Parce que du coup si le premier n'est pas le cookie permettant d'acceder a nomalab ca petera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants