Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolate between old foreground size and new one #132

Merged

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Aug 29, 2024

Previously there was some blinking when moving from one foreground-encoding to another, and especially when moving from a small, large selection to no selection at all. This tracks both the current and previous foreground states properly, and adds a test button on the FourClasses page to check it.

This was referenced Aug 29, 2024
Copy link
Collaborator Author

bmschmidt commented Aug 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bmschmidt and the rest of your teammates on Graphite Graphite

@bmschmidt bmschmidt marked this pull request as ready for review August 29, 2024 21:53
@bmschmidt bmschmidt force-pushed the 08-07-import_quadfeather_manifests branch from 6648de3 to 341d21e Compare August 30, 2024 21:59
@bmschmidt bmschmidt force-pushed the 08-29-interpolate_between_old_foreground_size_and_new_one branch from cbe07b8 to a6ba051 Compare August 30, 2024 21:59
@RLesser RLesser self-requested a review September 3, 2024 14:15
Copy link
Contributor

@RLesser RLesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

if (u_color_picker_mode >= 1.) {


// Color picking only rouns on background if background_mouseover is true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Color picking only rouns on background if background_mouseover is true.
// Color picking only runs on background if background_mouseover is true.

@bmschmidt bmschmidt changed the base branch from 08-07-import_quadfeather_manifests to dev September 3, 2024 15:19
@bmschmidt bmschmidt merged commit e02309d into dev Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants