Remove the deferred functions queue #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bmschmidt and the rest of your teammates on |
This was referenced Sep 9, 2024
Merged
Closed
This was referenced Sep 16, 2024
Merged
eelegiap
approved these changes
Sep 16, 2024
bmschmidt
force-pushed
the
09-07-longer_.gitignore
branch
from
6493407 to
a8e1293
Compare
bmschmidt
force-pushed
the
remove_deferred_functions_queue
branch
from
3f1e0d5 to
bc0cfea
Compare
Merge activity
|
bmschmidt
force-pushed
the
09-07-longer_.gitignore
branch
2 times, most recently
from
a5167e4 to
70e959a
Compare
bmschmidt
force-pushed
the
remove_deferred_functions_queue
branch
from
bc0cfea to
552887a
Compare
bmschmidt
changed the base branch from
09-07-longer_.gitignore
to
graphite-base/138
bmschmidt
force-pushed
the
remove_deferred_functions_queue
branch
from
552887a to
6a2a804
Compare
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -296,25 +294,6 @@ export class ReglRenderer extends Renderer { | |||
|
|
|||
| const start = Date.now(); | |||
There was a problem hiding this comment.
The call to pop_deferred_functions is now redundant and should be removed since the function and related code have been deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dead code, and is a pretty finicky thing that we could implement better.
refactor: remove unused deferred functions from rendering classes
Summary:
This pull request removes unused deferred functions from rendering classes to simplify the rendering process.
Key points:
deferred_functionsarray fromRendererclass insrc/rendering.ts.pop_deferred_functionsfunction fromReglRendererclass insrc/regl_rendering.ts.Generated with ❤️ by ellipsis.dev