Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model to its own crate #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elferherrera
Copy link

Proposal to move Prusto model to its own crate so it could be used by other projects that require to parse trino data but don't require a client

@nooberfsh
Copy link
Owner

Hi, Thanks for the PR.
At first I thought it was only the models are moved to a separate crate, not including the types, currently types are implemented in a very opinioned way and I don't think they are useful for other implementations, so I think the types should keep in the prusto crate.
Than I found models are depend on types which is unfortunate. Do you have any ideas about this.

@elferherrera
Copy link
Author

I'm slowly getting familiar with trino's response, so I don't know how the data is encoded. What made you select those types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants