Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Avatars with Colored Images #112

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Conversation

akirk
Copy link
Contributor

@akirk akirk commented May 10, 2024

This allows to distinguish local users via avatars based on the image color. It also doesn't override a locally provided image for example via https://github.com/10up/simple-local-avatars.

Screenshot 2024-05-10 at 09 47 26

@norcross
Copy link
Owner

my apologies for the delay, lemme take a look

@norcross
Copy link
Owner

in my testing, the trim() function on $id_or_email doesn't check if it's a comment object, which happens on the dashboard and front end. I'm going to edit this PR but otherwise it'll get in

this updates on the initial function from @akirk
updating changelog and readme file along with a version bump
general boring cleanup
@norcross norcross merged commit 565efc2 into norcross:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants