test_name: Fix name conversion for UnitTest methods. #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For UnitTest-wrapped functions, test_name() would convert a module.class.test_function into "module.test_function" and lose the class information. This is, unfortunately, not expected by the MultiProcess plugin, which has a different way of converting tests to their testids. This fix ensures for UnitTest-wrapped functions, test_name() returns a "module.class.function"-style name that complies with the manner that MultiProcess plugin expects. This PR fixes issue nose-devs#465.
ltfish
force-pushed
the
fix/util_test_name_transplanted_func
branch
from
7a81549 to
53f1746
Compare
ltfish
force-pushed
the
fix/util_test_name_transplanted_func
branch
from
53f1746 to
c6861db
Compare
|
Thanks for the PR. I've been trying to get time to review it and test it on some testsuites I have, but it hasn't happened yet. It seems right to me, but I want to at least turn #465 into a test-case to confirm that this works on all of our supported pythons before merging. |
method.__qualname__ does not play well with nose1 method wrappers (such as nose.tools.raises, which leads to something like `raises.<locals>.decorate.<locals>.newfunc`). Since this is a problem with nose1, I decide to work around it here by only touching the unittest-wrapped methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UnitTest-wrapped functions, test_name() would convert a
module.class.test_function into "module.test_function" and lose the
class information. This is, unfortunately, not expected by the
MultiProcess plugin, which has a different way of converting tests to
their testids. This fix ensures for UnitTest-wrapped functions,
test_name() returns a "module.class.function"-style name that complies
with the manner that MultiProcess plugin expects.
This PR fixes issue #465.