Infinite loop if no target #484
Labels
Comments
|
Loop is here. |
|
This should be fixed. Thanks for report. As a workaround it seems as if you add a |
sphaerophoria
added a commit
to sphaerophoria/atom-build
that referenced
this issue
Feb 27, 2017
In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. The fix is to pre-emptively check before the fillTargets call
sphaerophoria
added a commit
to sphaerophoria/atom-build
that referenced
this issue
Feb 27, 2017
In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. We don't actually need to call fillTargets as we already know which targets are available, we can just set them ourselves
sphaerophoria
added a commit
to sphaerophoria/atom-build
that referenced
this issue
Feb 27, 2017
In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. We have enough information to retrace the steps fillTargets currently takes so we can just set them ourselves
noseglid
added a commit
that referenced
this issue
May 22, 2017
Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447
noseglid
added a commit
that referenced
this issue
May 22, 2017
Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447
Merged
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I got the infinite loop of calls
isEligiblemethod for all build-providers. It happens if I have no any.atom-build.*-file;For localise & reproduce this issue I was create a new atom-plugin with empty provider contains
isEligible() { console.debug("LOOP HERE"); return false; }Steps for reproduce:
build:select-active-target(press F7 by default)The text was updated successfully, but these errors were encountered: