Buttons color Error

[JMGama]

The color of the buttons stays the same when you click it then you need to click other place to restore the original button color.
It's a little hard to explain.

[fleeting]

Wouldn't this be the correct behavior as your focus is still on the button since the button doesn't do anything?

[JMGama]

The button has a click function that ends and the button remains the same color, is that okay?

[jjspace]

It's because of how the styling is applied. It's changing the color on :focus of the button. Focus persists even after a click is done until you focus/click on something else. We could take the styling off of focus and just have it change on :hover and :active and this wouldn't happen. I personally think this might be better but that could be open to discussion.

[fleeting]

This is just because the hover and focus states use the same styles. For accessibility we should tweak the focus state to be different from the hover and normal state.

Ultimately what's happening is the inset style is from the active state, which happens when you click in. However, just like when you tab through the buttons with the keyboard, your focus is now on that button from the click and since focus and hover use the same styles - it just style looks the same.

We shouldn't remove focus but it's worth giving it it's own style.

[jjspace]

+1 for thinking of tab focus, I'd forgotten about that. In that case I think it might be best to keep the hover and focus styling the same for consistency right?

[fleeting]

At a minimum, they should be the same just so focus is set. I think we should come up with a new focus state, maybe remove the hover styles and add a decent outline. I'll do a pull request for some accessibility tweaks.

[abdallahalsamman]

I've tried reproducing this on safari and chrome(both OSX) but couldn't reproduce it.
Which browser are you on?

[fleeting]

I get it in Chrome on OS X, it's just the focus styles. https://github.com/nostalgic-css/NES.css/blob/master/scss/elements/buttons.scss#L6 should ideally be split up so focus has it's own unique styles different than the hover style.

[jjspace]

I can confirm that this happens in Chrome 70 on OSX and Chrome 70, FF 63 and Edge on Windows. However for some reason it does not seem like Safari and FF 63 keep focus state when you stop hovering on OSX so this problem does not exist there.
I think it might be worth separating the styles to handle them independently but with the fact that tab focus is essentially the mouse-less equivalent of hover I think they should stay the same style if not very similar. The "bug" just has to do with how browsers handle focus state and not really something we could get around while maintaining similar styles for both

[abdallahalsamman]

I see.
@fleeting are you still going to open a PR for this issue? 🙈

[youngkaneda]

So what would be better, remove the effect in focus, or add a different focus effect? Since they are the same.

[BcRikko]

https://github.com/nostalgic-css/NES.css/blob/master/scss/elements/buttons.scss#L6 should ideally be split up so focus has it's own unique styles different than the hover style.

I agree 👍

---

I splitted the focus and hover styles. ✂️

// buttons.scss
@mixin btn-style($color, $background, $hover-background, $shadow) {
  //...
  &:focus {
    box-shadow: 0 0 0 6px rgba($shadow, 0.3);
  }
  //...
}

[JMGama]

I think the shadow of the focus looks a little weird, but it's great that now the styles are splitted. 👍

[youngkaneda]

a simple and great solution

[BcRikko]

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀