Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add components dir and split css file #224

Merged
merged 6 commits into from
Dec 28, 2018
Merged

Add components dir and split css file #224

merged 6 commits into from
Dec 28, 2018

Conversation

BcRikko
Copy link
Member

@BcRikko BcRikko commented Dec 23, 2018 •
edited
Loading

ref #166

Description

file size(KB)
nes-core.css 34KB
nes-core.min.css 29KB
nes.css 254KB
nes.min.css 236KB

Compatibility
none

Caveats
none

@BcRikko BcRikko self-assigned this Dec 23, 2018
@BcRikko BcRikko changed the title [WIP]Add components dir and split css file Add components dir and split css file Dec 23, 2018
@BcRikko BcRikko requested a review from a team December 23, 2018 14:37
@BcRikko BcRikko added documentation Adding, removing, or updating documentation devops CI, build, and deployment issues labels Dec 23, 2018
@BcRikko BcRikko changed the title Add components dir and split css file [WIP]Add components dir and split css file Dec 23, 2018
@BcRikko BcRikko changed the title [WIP]Add components dir and split css file Add components dir and split css file Dec 23, 2018
abdallahalsamman
abdallahalsamman approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@abdallahalsamman abdallahalsamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@abdallahalsamman abdallahalsamman merged commit 3eacba9 into develop Dec 28, 2018
@abdallahalsamman abdallahalsamman deleted the file-management branch December 28, 2018 23:00
@BcRikko
Copy link
Member Author

BcRikko commented Feb 16, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdallahalsamman abdallahalsamman abdallahalsamman approved these changes

Assignees

@BcRikko BcRikko

Labels
devops CI, build, and deployment issues documentation Adding, removing, or updating documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BcRikko @abdallahalsamman