feat(component-balloons): Dark Mode - Balloons #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation so balloons can now have `is-dark` re nostalgic-css#345
guastallaigor
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Thanks for your contribution 🎉
Sorry about the delay.
I tested it and LGTM 👍
There are some basic stylelint errors, and an example should be also added in index.html, but since it took me a few this, I will merge this for now.
Feel free to add this is the index.html sometime later. I will handle the lint errors in another PR.
|
@HiKaylum Thanks for your contribute 🎉 @guastallaigor Thanks for merging. 🙇 |
Merged
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation so balloons can now have
is-darkre #345
Description
Exactly what it says on the tin, I have added the ability for balloons to be displayed in dark mode.
Screen:
Compatibility
Non-breaking, tis a small change. However I did add a mixin due to repeating scss.
Caveats
None