Clarify what happens when a duplicate subscription is sent, remove CLOSED on duplicate subscription #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OSED on duplicate subscription
mikedilger
approved these changes
Jun 28, 2024
|
LGTM! |
|
Ping @fiatjaf |
| @@ -169,7 +169,6 @@ This NIP defines no rules for how `NOTICE` messages should be sent or treated. | |||
| * `["OK", "b1a649ebe8...", false, "pow: difficulty 26 is less than 30"]` | |||
| * `["OK", "b1a649ebe8...", false, "error: could not connect to the database"]` | |||
| - `CLOSED` messages MUST be sent in response to a `REQ` when the relay refuses to fulfill it. It can also be sent when a relay decides to kill a subscription on its side before a client has disconnected or sent a `CLOSE`. This message uses the same pattern of `OK` messages with the machine-readable prefix and human-readable message. Some examples: | |||
| * `["CLOSED", "sub1", "duplicate: sub1 already opened"]` | |||
There was a problem hiding this comment.
Suggest we replace this example with one that may lead to more relays enforcing the max sub id length
["CLOSED", "sub1", "error: subscription id too large"]
|
ACK |
cameri
approved these changes
Aug 31, 2024
fiatjaf
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1332