Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing events added to README, including NKBIP-01 and NKBIP-02 #1464

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Missing events added to README, including NKBIP-01 and NKBIP-02 #1464

merged 7 commits into from
Sep 3, 2024

Conversation

SilberWitch
Copy link
Contributor

I updated the Nostr Event Register to include the new entries in this repo and I am now proposing the additions from my own list, so that the two are again comprehensive.

I also corrected a wiki link that was broken.

@staab
Copy link
Member

staab commented Sep 1, 2024

Hmmm 1986 appears to be overloaded. I've been using it for almost a year for relay reviews. Who gets to keep their kind?

@AsaiToshiya
Copy link
Collaborator

Blossom seems to use kind:10063 in BUD-03. What is the reason for no adding it?

@SilberWitch
Copy link
Contributor Author

We can move to 1987. No problem. Only writing test data, so far.
I'll add your 1986. Do you have a link to the spec for it, @staab?

He'd only listed the one. I'll read through his newer specs and add the missing ones.

@SilberWitch
Copy link
Contributor Author

Nevermind. Found the 1986 PR and made a wiki page to link to.

https://wikistr.com/nip-85

@SilberWitch
Copy link
Contributor Author

Sorry for the messy commits. Should be correct, now.

README.md Outdated
@@ -131,6 +131,8 @@ They exist to document what may be implemented by [Nostr](https://github.com/nos
| `1971` | Problem Tracker | [nostrocket][nostrocket] |
| `1984` | Reporting | [56](56.md) |
| `1985` | Label | [32](32.md) |
| `1986` | Relay reviews | [NIP-85] |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it is appropriate to add NIP kind that is not yet merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind, if you change the link. You could link to the PR, but it is also called NIP-85.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but this makes PRs second class citizens compared to wikifreedia entriea. Maybe we should have a "unmerges and third party" kinds table?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, fiatjaf's changes look good.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fiatjaf fiatjaf merged commit 14ec14d into nostr-protocol:master Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants