-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing events added to README, including NKBIP-01 and NKBIP-02 #1464
Conversation
Hmmm 1986 appears to be overloaded. I've been using it for almost a year for relay reviews. Who gets to keep their kind? |
Blossom seems to use |
We can move to 1987. No problem. Only writing test data, so far. He'd only listed the one. I'll read through his newer specs and add the missing ones. |
Nevermind. Found the 1986 PR and made a wiki page to link to. |
Sorry for the messy commits. Should be correct, now. |
README.md
Outdated
@@ -131,6 +131,8 @@ They exist to document what may be implemented by [Nostr](https://github.com/nos | |||
| `1971` | Problem Tracker | [nostrocket][nostrocket] | | |||
| `1984` | Reporting | [56](56.md) | | |||
| `1985` | Label | [32](32.md) | | |||
| `1986` | Relay reviews | [NIP-85] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it is appropriate to add NIP kind that is not yet merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, if you change the link. You could link to the PR, but it is also called NIP-85.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but this makes PRs second class citizens compared to wikifreedia entriea. Maybe we should have a "unmerges and third party" kinds table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, fiatjaf's changes look good.
I updated the Nostr Event Register to include the new entries in this repo and I am now proposing the additions from my own list, so that the two are again comprehensive.
I also corrected a wiki link that was broken.