NullPointerException in LruMemoryCache

[gildor]

Hi! We have some rare (1 per 2000 users) errors in logs with UIL 1.8.3.
All users have Android 2.X

java.lang.NullPointerException: key == null || value == null
    at com.nostra13.universalimageloader.cache.memory.impl.LruMemoryCache.put(LruMemoryCache.java:61)
    at com.nostra13.universalimageloader.cache.memory.impl.LruMemoryCache.put(LruMemoryCache.java:21)
    at com.nostra13.universalimageloader.core.LoadAndDisplayImageTask.run(LoadAndDisplayImageTask.java:116)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1088)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:581)
    at java.lang.Thread.run(Thread.java:1019)

our configuration:

DisplayImageOptions.Builder builder = new DisplayImageOptions.Builder();
        builder.cacheInMemory();
        builder.cacheOnDisc();
        builder.resetViewBeforeLoading();
        builder.showImageForEmptyUri(R.drawable.im_photo_error);

[nostra13]

Thanks for bug. I'll investigate it.

DisplayImageOptions is display options. Can you provide your configuration (ImageLoaderConfiguration)?

[gildor]

My configuration is simple:

ImageLoaderConfiguration.Builder builder = new ImageLoaderConfiguration.Builder(mContext);
        if (App.DEBUG) {
            builder.enableLogging();
        }
        builder.discCacheSize(DISC_CACHE_SIZE);
        builder.defaultDisplayImageOptions(getDisplayImageConfig().build());

where getDisplayImageConfig is listed above

[nostra13]

Mystery. Can't imagine how it can happens. Don't you really use any pre-processor?

[gildor]

Sorry, you're right. In some cases, we use preprocessor:

public class MaskClipProcessor implements BitmapProcessor {

    public static final int DEFAULT_MASK = R.drawable.user_mask_album;
    private final Bitmap mMask;
    private static HashMap<Integer, Bitmap> cachedMaskBitmaps = new HashMap<Integer, Bitmap>();

    public MaskClipProcessor(int mask) {
        if (cachedMaskBitmaps.containsKey(mask)) {
            mMask = cachedMaskBitmaps.get(mask);
        } else {
            mMask = BitmapFactory.decodeResource(App.getContext().getResources(), mask);
            cachedMaskBitmaps.put(mask, mMask);
        }
    }

    @Override
    public Bitmap process(Bitmap bitmap) {
        return Utils.getRoundedCornerBitmapByMask(bitmap, mMask);
    }

}

[nostra13]

I'll fix it, NPE won't be thrown, UIL will display null (nothing) if you return it. But I recommend you to return original bitmap if processing failed.