WIP: Add a no-op server endpoint for rotating keys, and make the client use it #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| err error | ||
| ) | ||
| switch role { | ||
| switch s.role { // parseKeyParams ensures it's only timestamp or snapshot |
There was a problem hiding this comment.
Note - this logic goes away and GetOrCreateXKey gets unified in the next PR.
|
awesome tests, LGTM pending comments! |
Signed-off-by: Ying Li <[email protected]>
This also changes GetKey and RotateKey to return a data.PublicKey, rather than bytes. Signed-off-by: Ying Li <[email protected]>
… rotating keys. Signed-off-by: Ying Li <[email protected]>
Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
server-rotate-handler
branch
from
5b46db7 to
c04f9a5
Compare
|
@riyazdf @NathanMcCauley thanks for the quick review! I've just made a new function |
…motely. Signed-off-by: Ying Li <[email protected]>
cyli
changed the title
|
Marking as WIP due to some discussion on #534 that may change how this works |
|
Since so much has changed, opening new request #533 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR for the full server rotation of keys was getting a bit big, so here are some cherry-picked parts.
Currently the endpoint always returns a 429 (rate limit).
Part of #347