Reissue certs #842
Merged
Reissue certs #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
|
This is awesome, thank you so much for fixing this quickly! When I ran it, it also generated a Other than that, which is non-blocking, this LGTM! Would love to get this merged ASAP to fix the CircleCI runs! |
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
|
@cyli ah yes -- just updated to remove that, thanks for running and pointing that out :) |
|
LGTM |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reissues certs for notary-server, notary-signer, secure.example.com (which were all expired). These will expire again in a year, and use the same private key material.
Also reissued root-ca and intermediate-ca, and removed private key material upon creation. These certs will expire in 10 years.
Closes #840
Signed-off-by: Riyaz Faizullabhoy [email protected]