fix: fix signerInfo.authenticSigningTime according to spec
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 90.43% 90.88% +0.45%
==========================================
Files 26 26
Lines 1777 1778 +1
==========================================
+ Hits 1607 1616 +9
+ Misses 120 112 -8
Partials 50 50 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Jul 15, 2024
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
changed the title
signerInfo.authenticSigningTime according to spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
signerInfo.AuthenticSigningTimeto return the correct results.According to spec: https://github.com/notaryproject/specifications/blob/main/specs/signature-specification.md#signing-time--authentic-signing-time:
authentic signing timeis a valid concept only under signing schemenotary.x509.signingAuthority. Therefore, for other signing schemes, this function should return an error.Resolves #38