-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: dir package [1] #179
Conversation
f940754
to
60cd11a
Compare
Signed-off-by: Junjie Gao <[email protected]>
60cd11a
to
1ca0957
Compare
Signed-off-by: Junjie Gao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 82.37% 80.25% -2.12%
==========================================
Files 23 22 -1
Lines 1821 1722 -99
==========================================
- Hits 1500 1382 -118
- Misses 254 266 +12
- Partials 67 74 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please review this PR before others.
Signed-off-by: Junjie Gao [email protected]