-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for signed user metadata #242
Conversation
Signed-off-by: Byron Chien <[email protected]>
related: notaryproject/notation#507 |
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 73.31% 73.34% +0.03%
==========================================
Files 23 23
Lines 1746 1827 +81
==========================================
+ Hits 1280 1340 +60
- Misses 372 390 +18
- Partials 94 97 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Shouldn't the error message be something like, |
Signed-off-by: Byron Chien <[email protected]>
Signed-off-by: Byron Chien <[email protected]>
Signed-off-by: Byron Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Byron Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
Signed-off-by: Byron Chien <[email protected]>
Signed-off-by: Byron Chien <[email protected]>
Signed-off-by: Byron Chien <[email protected]>
6deec4a
to
aa647a9
Compare
@byronchien could you fix the conflicts? |
resolved conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds support for signed user metadata in
notation sign
andnotation verify
. Relevant specexample sign usage:
example metadata displayed on verification (without metadata flag)
example verification:
example verification failure
Signed-off-by: Byron Chien [email protected]