-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more logs for timestamp validation #1004
Comments
yizha1
changed the title
Add warning logs for expired certificates during timestamp validation
Add more logs for expired certificates during timestamp validation
Aug 9, 2024
yizha1
changed the title
Add more logs for expired certificates during timestamp validation
Add more logs for timestamp validation
Aug 9, 2024
priteshbandi
pushed a commit
to notaryproject/notation-go
that referenced
this issue
Oct 16, 2024
This PR updates logs. Resolves #430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Closing as completed. |
github-project-automation
bot
moved this from Todo
to Done
in Notary Project Planning Board
Nov 13, 2024
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 9, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 9, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 9, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 10, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
added a commit
to Two-Hearts/notation-go
that referenced
this issue
Dec 10, 2024
This PR updates logs. Resolves notaryproject#430. Also should resolve issue notaryproject/notation#1004. Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
When using the
notation verify
command to validate a signature with timestamp validation enabled, the signature verification succeeds even if the signing certificate has expired, provided the signature was generated before the certificate’s expiry. This behavior is expected. However, the verbose log output is not informative, as shown below:What solution do you propose?
The current log indicates that timestamp validation is enabled and is now validating the timestamp:
Subsequently, the log shows the TSA identity:
It is proposed to enhance the log output to provide more detailed information about the timestamp verification process. For example, the log should indicate whether each certificate in the certificate chain has expired or not.
Examples for valid certificates:
Examples for an expired leaf certificate:
Additionally, we can make it more clear about what TSA identity is
What alternatives have you considered?
There could be other information printed out for timestamp validation. Any suggestions are welcome.
Any additional context?
Notation v1.2.0-beta.1
The text was updated successfully, but these errors were encountered: