Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notation sign/verify to work with local storage #283

Closed
Tracked by #15
dtzar opened this issue Aug 5, 2022 · 5 comments · Fixed by #595
Closed
Tracked by #15

notation sign/verify to work with local storage #283

dtzar opened this issue Aug 5, 2022 · 5 comments · Fixed by #595
Assignees
@patrickzheng200 @yizha1
Milestone
RC-4

Comments

@dtzar
Copy link
Contributor

dtzar commented Aug 5, 2022

Implement notation to work with signatures in the local storage/filesystem.
This was referenced Aug 5, 2022
Closed
Open
@sajayantony
Copy link
Contributor

Sharing a proposal here - https://hackmd.io/5PmzMOcrSRaCUJzuy_Gbhg
@gokarnm @toddysm @shizhMSFT

@toddysm
Copy link
Contributor

toddysm commented Nov 11, 2022

@FeynmanZhou @yizha1 @vaninrao10 is this something we can consider for rc.2?

@dtzar
Copy link
Contributor Author

dtzar commented Nov 11, 2022

@toddysm - the bigger user story is set for RC2, but needs more clarity on scope. Please comment more on this thread which aspect of "local" you desire.

@priteshbandi priteshbandi added this to the future milestone Nov 23, 2022
@shizhMSFT shizhMSFT mentioned this issue Jan 29, 2023
Open
@yizha1
Copy link
Contributor

yizha1 commented Feb 22, 2023

Update the milestone to rc-3 based on the discussion.

@yizha1 yizha1 modified the milestones: future, RC-3 Feb 22, 2023
@yizha1 yizha1 moved this from Todo to In Progress in Notary Project Planning Board Feb 22, 2023
@patrickzheng200
Copy link
Contributor

Working on this item, design in progress.

@vaninrao10 vaninrao10 modified the milestones: RC-3, RC-4 Mar 1, 2023
@patrickzheng200 patrickzheng200 linked a pull request Mar 23, 2023 that will close this issue
feat: add local sign/list/verification for OCI layout directory #595
Merged
@patrickzheng200 patrickzheng200 mentioned this issue Mar 23, 2023
Merged
shizhMSFT pushed a commit that referenced this issue Apr 20, 2023
@Two-Hearts
feat: add local sign/list/verification for OCI layout directory (#595)
17d3525 
This PR adds local sign/list/verification for OCI image layout
directory.
For RC.4:
1. It only supports storing the generated signature into the target OCI
layout directory.
2. It supports listing signatures within the OCI layout directory.
3. It only supports verifying signatures within the target OCI layout
directory.

This PR is based on spec PR:
#601 (Merged).

This PR is dependent on the corresponding notation-go PR:
notaryproject/notation-go#288.
Please review the notation-go PR first.

Resolves #283.

Both remote registry and oci-layout scenario are tested. E2E tests are
also included.

---------

Signed-off-by: Patrick Zheng <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Notary Project Planning Board Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickzheng200 patrickzheng200

@yizha1 yizha1

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
RC-4
Development

Successfully merging a pull request may close this issue.

feat: add local sign/list/verification for OCI layout directory patrickzheng200/notation
7 participants
@toddysm @sajayantony @dtzar @priteshbandi @patrickzheng200 @yizha1 @vaninrao10