doc: add missing username/password options to commands #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Binbin Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
===========================================
- Coverage 61.07% 30.64% -30.43%
===========================================
Files 9 25 +16
Lines 280 1612 +1332
===========================================
+ Hits 171 494 +323
- Misses 102 1105 +1003
- Partials 7 13 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dtzar
approved these changes
Aug 16, 2022
|
@yizha1 - since this is just a doc fix and is now at the 1 week mark, I recommend merging it today before notation release. |
Good call, I'll add it. |
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
fix-cli-spec
branch
2 times, most recently
from
eebfa63 to
0929fd3
Compare
Signed-off-by: Binbin Li <[email protected]>
binbin-li
force-pushed
the
fix-cli-spec
branch
from
0929fd3 to
262cc16
Compare
chloeyin
added a commit
that referenced
this pull request
Aug 25, 2022
* doc: add missing username/password options to commands (#293) Signed-off-by: Binbin Li <[email protected]> * bump up version to v0.10.0-alpha.3 (#301) * bump up version to v1.0.0-alpha.3 * revise version to v0.10.0-alpha.3 Signed-off-by: Yi Zha <[email protected]> * fix: update notation-go (#294) Signed-off-by: Junjie Gao <[email protected]> * Build: Bump dependencies (#306) Signed-off-by: Yi Zha <[email protected]> * feat: add weekly release (#282) Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Binbin Li <[email protected]> Signed-off-by: Yi Zha <[email protected]> Signed-off-by: Junjie Gao <[email protected]> Co-authored-by: Binbin Li <[email protected]> Co-authored-by: Yi Zha <[email protected]> Co-authored-by: Junjie Gao <[email protected]> Co-authored-by: zaihaoyin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resovles #276
For commands other than
notation login, we should allow them supportusername/passwordoptions even without first-time logging.Since the
logincommand requirescredentialsStoreset up which might be missing for users. So we cannot force users always useloginto save credentials. Other commands should be able to use the credentials directly from input withoutcredentialsStoreset up.Updated commands:
Signed-off-by: Binbin Li [email protected]