Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve readability of directory spec #311

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

shizhMSFT
Copy link
Contributor

Improve readability of directory spec without changing the underlying directory structures.

Resolves #220
Signed-off-by: Shiwei Zhang [email protected]

@shizhMSFT shizhMSFT requested review from SteveLasker, FeynmanZhou, yizha1 and a team August 24, 2022 06:25
@shizhMSFT
Copy link
Contributor Author

/cc @JeyJeyGao

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #311 (dbf9374) into main (e73bfc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   30.66%   30.66%           
=======================================
  Files          25       25           
  Lines        1611     1611           
=======================================
  Hits          494      494           
  Misses       1104     1104           
  Partials       13       13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Shiwei Zhang <[email protected]>
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @SteveLasker @NiazFK this is ready to be merged.

@JeyJeyGao
Copy link
Contributor

LGTM

@shizhMSFT shizhMSFT merged commit 8bec8a7 into notaryproject:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify LibEx directory on Windows
6 participants