Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated the expiry flag of notation cert generate-test #313

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

patrickzheng200
Copy link
Contributor

removed the expiry flag of 'notation cert generate-test' command

Resolves #312

Signed-off-by: Patrick Zheng [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #313 (99c4520) into main (e73bfc3) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   30.66%   30.62%   -0.05%     
==========================================
  Files          25       25              
  Lines        1611     1610       -1     
==========================================
- Hits          494      493       -1     
  Misses       1104     1104              
  Partials       13       13              
Impacted Files Coverage Δ
cmd/notation/cert.go 35.29% <ø> (-0.48%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT requested review from a team August 25, 2022 02:13
@shizhMSFT shizhMSFT added this to the RC-1 milestone Aug 25, 2022
@patrickzheng200 patrickzheng200 changed the title deprecated the expiry flag of notation cert generate-test fix: deprecated the expiry flag of notation cert generate-test Aug 25, 2022
Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shizhMSFT shizhMSFT merged commit 6dd40fb into notaryproject:main Sep 1, 2022
@patrickzheng200 patrickzheng200 deleted the rmvExpiry branch September 26, 2022 03:42
@vaninrao10 vaninrao10 modified the milestones: RC-1, alpha-4 Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove unused options for notation cert generate-test
6 participants