feat: implement list command UX #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeyJeyGao
force-pushed
the
junjiegao/spec_list
branch
4 times, most recently
from
d85c3f2 to
22f8c2a
Compare
According to: https://github.com/notaryproject/notation/blob/main/specs/commandline/list.md Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
junjiegao/spec_list
branch
from
22f8c2a to
2682b8b
Compare
shizhMSFT
reviewed
Oct 27, 2022
shizhMSFT
requested changes
Oct 27, 2022
JeyJeyGao
force-pushed
the
junjiegao/spec_list
branch
from
bc649f3 to
d81b6b1
Compare
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 34.60% 33.18% -1.43%
==========================================
Files 23 21 -2
Lines 1254 1094 -160
==========================================
- Hits 434 363 -71
+ Misses 809 722 -87
+ Partials 11 9 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
force-pushed
the
junjiegao/spec_list
branch
from
d81b6b1 to
58c9fa8
Compare
shizhMSFT
approved these changes
Oct 31, 2022
JeyJeyGao
force-pushed
the
junjiegao/spec_list
branch
2 times, most recently
from
36c96a7 to
c431d58
Compare
priteshbandi
approved these changes
Oct 31, 2022
Comment on lines
+67
to
+68
| // TODO: this is a temporary function and will be replaced after | ||
| // notation-go refactor. |
There was a problem hiding this comment.
Can you please open an issue to track this?
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
junjiegao/spec_list
branch
from
c431d58 to
fb00153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to: https://github.com/notaryproject/notation/blob/main/specs/commandline/list.md
Updated
listcommand outputSigned-off-by: Junjie Gao [email protected]