Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement plugin UX #415

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Oct 26, 2022

According https://github.com/notaryproject/notation/blob/main/specs/commandline/plugin.md.

Updated help message.
Updated spec: replace "<command>" with "[command]" because the format is defined in cobra template.

Signed-off-by: Junjie Gao [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #415 (c928359) into main (f747031) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   34.60%   34.60%           
=======================================
  Files          23       23           
  Lines        1254     1254           
=======================================
  Hits          434      434           
  Misses        809      809           
  Partials       11       11           
Impacted Files Coverage Δ
cmd/notation/plugin.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1 yizha1 added this to the beta-1 milestone Oct 26, 2022
@yizha1 yizha1 linked an issue Oct 26, 2022 that may be closed by this pull request
Signed-off-by: Junjie Gao <[email protected]>
Copy link

@jondonas jondonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit f947da5 into notaryproject:main Oct 27, 2022
@yizha1 yizha1 removed this from the beta-1 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implementing plugin command
6 participants