Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --debug & --verbose flags & http request/response debug log #457

Merged
merged 17 commits into from
Dec 5, 2022
Merged

feat: add --debug & --verbose flags & http request/response debug log #457

merged 17 commits into from
Dec 5, 2022

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Nov 28, 2022 •
edited
Loading

  • added debug flag for sign/verify commands
  • added verbose flag for sign/verify commands
  • added http request/response debug log

Signed-off-by: Junjie Gao [email protected]

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2022
View reviewed changes
internal/trace/transport.go Fixed Show resolved Hide resolved
patrickzheng200
patrickzheng200 reviewed Nov 28, 2022
View reviewed changes
internal/cmd/options.go Outdated Show resolved Hide resolved
internal/cmd/options.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao force-pushed the feat/add_debug branch 2 times, most recently from 8988dec to acb73ce Compare November 30, 2022 04:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022 •
edited
Loading

Codecov Report

Merging #457 (145daab) into main (0af4a82) will decrease coverage by 0.29%.
The diff coverage is 6.81%.

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   32.40%   32.10%   -0.30%     
==========================================
  Files          25       25              
  Lines        1290     1305      +15     
==========================================
+ Hits          418      419       +1     
- Misses        860      874      +14     
  Partials       12       12
Impacted Files Coverage Δ
cmd/notation/list.go 23.28% <0.00%> (ø)
cmd/notation/login.go 42.68% <0.00%> (ø)
cmd/notation/manifest.go 0.00% <0.00%> (ø)
cmd/notation/registry.go 0.00% <0.00%> (ø)
cmd/notation/sign.go 43.18% <14.28%> (-1.53%) ⬇️
cmd/notation/verify.go 29.03% <18.18%> (+1.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

patrickzheng200
patrickzheng200 reviewed Dec 1, 2022
View reviewed changes
cmd/notation/sign.go Show resolved Hide resolved
cmd/notation/sign.go Outdated Show resolved Hide resolved
internal/cmd/options.go Outdated Show resolved Hide resolved
cmd/notation/verify.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao force-pushed the feat/add_debug branch 2 times, most recently from 30a9b05 to 92625e9 Compare December 1, 2022 08:16
shizhMSFT
shizhMSFT reviewed Dec 1, 2022
View reviewed changes
internal/trace/context.go Outdated Show resolved Hide resolved
internal/ioutil/print.go Outdated Show resolved Hide resolved
cmd/notation/registry.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao changed the title feat: add http request/response debug log feat: add --debug & --verbose flag & http request/response debug log Dec 2, 2022
@JeyJeyGao JeyJeyGao changed the title feat: add --debug & --verbose flag & http request/response debug log feat: add --debug & --verbose flags & http request/response debug log Dec 2, 2022
priteshbandi
priteshbandi reviewed Dec 2, 2022
View reviewed changes
internal/cmd/options.go Show resolved Hide resolved
cmd/notation/registry.go Outdated Show resolved Hide resolved
@JeyJeyGao
feat: update log
f0fd009 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: update log
d8c6190 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: resolve comments
149d25c 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: resolve comments
415eab7 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
feat: add verbose flag
b673b1c 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: resolve comment
f3b2d7f 
Signed-off-by: Junjie Gao <[email protected]>
patrickzheng200
patrickzheng200 suggested changes Dec 2, 2022
View reviewed changes
cmd/notation/verify.go Outdated Show resolved Hide resolved
cmd/notation/verify.go Outdated Show resolved Hide resolved
cmd/notation/verify.go Outdated Show resolved Hide resolved
cmd/notation/sign.go Outdated Show resolved Hide resolved
patrickzheng200
patrickzheng200 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2022
View reviewed changes
internal/trace/transport.go Fixed Show fixed Hide fixed
shizhMSFT
shizhMSFT reviewed Dec 2, 2022
View reviewed changes
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/context.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
internal/trace/transport.go Outdated Show resolved Hide resolved
cmd/notation/registry.go Outdated Show resolved Hide resolved
cmd/notation/registry.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao force-pushed the feat/add_debug branch 2 times, most recently from f8c7583 to d696d55 Compare December 5, 2022 02:28
@JeyJeyGao
fix: resolve comments
a75b525 
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
shizhMSFT reviewed Dec 5, 2022
View reviewed changes
cmd/notation/registry.go Outdated Show resolved Hide resolved
cmd/notation/registry.go Outdated Show resolved Hide resolved
cmd/notation/registry.go Outdated Show resolved Hide resolved
priteshbandi
priteshbandi approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Dec 5, 2022
View reviewed changes
cmd/notation/registry.go Outdated Show resolved Hide resolved
patrickzheng200
patrickzheng200 reviewed Dec 5, 2022
View reviewed changes
internal/cmd/options.go Outdated Show resolved Hide resolved
internal/trace/context.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: resolve comments
4f04ea8 
Signed-off-by: Junjie Gao <[email protected]>
patrickzheng200
patrickzheng200 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
fix: resolve comments
c789f57 
Signed-off-by: Junjie Gao <[email protected]>
@JeyJeyGao
fix: resolve comment
994a564 
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
shizhMSFT approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit e6b2e8c into notaryproject:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah left review comments

@yizha1 yizha1 yizha1 left review comments

@vaninrao10 vaninrao10 vaninrao10 left review comments

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@patrickzheng200 patrickzheng200 patrickzheng200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JeyJeyGao @codecov-commenter @qweeah @priteshbandi @shizhMSFT @patrickzheng200 @yizha1 @vaninrao10