Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: updated plugin list command #461

Merged
merged 33 commits into from
Dec 2, 2022

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Dec 1, 2022

This PR mainly fixed the plugin list command.
Previously, if there's an error on getting a plugin, only the error will be printed out.
In this PR, on error, the pluginName will also be printed out along with the error.
(This PR also includes some of the minor cleanups of notation CLI.)

Signed-off-by: Patrick Zheng [email protected]

@patrickzheng200 patrickzheng200 changed the title update: quick fix plugin list command update: updated plugin list command Dec 1, 2022
@patrickzheng200 patrickzheng200 self-assigned this Dec 1, 2022
@patrickzheng200 patrickzheng200 added this to the RC-1 milestone Dec 1, 2022
cmd/notation/plugin.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #461 (9fb2e7f) into main (86287b5) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   32.48%   32.19%   -0.29%     
==========================================
  Files          25       25              
  Lines        1250     1261      +11     
==========================================
  Hits          406      406              
- Misses        832      843      +11     
  Partials       12       12              
Impacted Files Coverage Δ
cmd/notation/cert/generateTest.go 16.52% <0.00%> (-0.15%) ⬇️
cmd/notation/cert/list.go 13.55% <0.00%> (-0.24%) ⬇️
cmd/notation/key.go 24.75% <0.00%> (ø)
cmd/notation/plugin.go 0.00% <0.00%> (ø)
cmd/notation/verify.go 22.07% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/notation/plugin.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

cmd/notation/plugin.go Outdated Show resolved Hide resolved
cmd/notation/plugin.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
cmd/notation/plugin.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a6dbab8 into notaryproject:main Dec 2, 2022
@patrickzheng200 patrickzheng200 deleted the plugin branch December 2, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants