Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: clean up notation CLI #485

Merged
merged 10 commits into from
Dec 20, 2022
Merged

cleanup: clean up notation CLI #485

merged 10 commits into from
Dec 20, 2022

Conversation

patrickzheng200
Copy link
Contributor

This PR intends to resolve #446, #477.

@Two-Hearts
clean up notation CLI
3184e46 
Signed-off-by: Patrick Zheng <[email protected]>
@patrickzheng200 patrickzheng200 self-assigned this Dec 14, 2022
@patrickzheng200 patrickzheng200 added the triage Need to triage label Dec 14, 2022
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Dec 14, 2022
@patrickzheng200 patrickzheng200 linked an issue Dec 14, 2022 that may be closed by this pull request
Consider more verbose error messages by default #477
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #485 (92b16a5) into main (b8ce43a) will decrease coverage by 0.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
- Coverage   32.33%   31.80%   -0.54%     
==========================================
  Files          25       25              
  Lines        1336     1327       -9     
==========================================
- Hits          432      422      -10     
- Misses        892      893       +1     
  Partials       12       12
Impacted Files Coverage Δ
cmd/notation/verify.go 27.00% <0.00%> (-0.28%) ⬇️
internal/envelope/envelope.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Two-Hearts
update
f2349e8 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
204e51b 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Dec 19, 2022
View reviewed changes
cmd/notation/verify.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
206d0d7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolved conflicts
e11d7f1 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Dec 19, 2022
View reviewed changes
cmd/notation/verify.go Outdated Show resolved Hide resolved
@Two-Hearts
update per code review
14b61b6 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Dec 19, 2022
View reviewed changes
cmd/notation/verify.go Outdated Show resolved Hide resolved
@Two-Hearts
update
1d2304e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
3456d2f 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Dec 19, 2022
View reviewed changes
cmd/notation/verify.go Outdated Show resolved Hide resolved
cmd/notation/verify.go Outdated Show resolved Hide resolved
@Two-Hearts
update
92b16a5 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 6346a87 into notaryproject:main Dec 20, 2022
@patrickzheng200 patrickzheng200 deleted the cleanup branch December 20, 2022 06:30
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
d5560d9 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
6a2f01d 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
28bc052 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
a8f6adc 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
796e0dd 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
7dec65b 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 5, 2023
@Two-Hearts @vaninrao10
cleanup: clean up notation CLI (notaryproject#485)
8ff4bf2 
This PR intends to resolve notaryproject#446, notaryproject#477.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: vaninrao10 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao JeyJeyGao is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

Assignees

@patrickzheng200 patrickzheng200

Labels
triage Need to triage
Projects
None yet
Milestone
RC-2
Development

Successfully merging this pull request may close these issues.

Consider more verbose error messages by default Deadcode cleanup improvement Notation
5 participants
@patrickzheng200 @codecov-commenter @priteshbandi @shizhMSFT @Two-Hearts