fix: add error handling for LoadConfigOnce() #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeyJeyGao
requested review from
rgnote,
priteshbandi,
shizhMSFT and
patrickzheng200
JeyJeyGao
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 35.15% 36.50% +1.34%
==========================================
Files 29 29
Lines 1502 1504 +2
==========================================
+ Hits 528 549 +21
+ Misses 955 936 -19
Partials 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
changed the title
JeyJeyGao
changed the title
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
test/pkg_configutil
branch
from
7f7718b to
14e8173
Compare
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
test/pkg_configutil
branch
from
61b5fa8 to
2fa2a90
Compare
priteshbandi
reviewed
Feb 7, 2023
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
force-pushed
the
test/pkg_configutil
branch
from
77bc3af to
860c382
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error handling.
Added unit test.
#516
Resolves #525
Signed-off-by: Junjie Gao [email protected]